Conversation
|
|
|
I don't think you want to move the Node logo to the bottom of the README |
|
Can you leave the logo up top? |
|
Sorry about the logo, already pushed fix. |
|
Also, isn't this down a bit far? What about just under the first paragraph-ish? |
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, but to be honest, I think it looks a little out of place and might be better off removed.
IMHO it works perfectly as a footnote (but I'm admittedly design-blind). Let's see what others think. |
|
Looks fine there to me. From #6819 it sounds like it was some work to get it, so we might as well keep it. |
|
We are essentially hiding it which doesn't makes sense imo. I think the scope of a badge is to be visible. |
f28d611 to
abdbfff
Compare
|
It still seems misplaced to me but definitely better than before. |
Where do you think it should be? |
|
@gibfahn I think below the logo, where it is now, is the best place maybe left aligned instead of centered. |
Fair enough, maybe we should just leave it where it is then |
|
Consensus seems to be to stay as it |

Follow up to #13231 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc