readline: numeric strings converted to integers in cursorTo#13271
Closed
petekeller2 wants to merge 2 commits intonodejs:masterfrom
Closed
readline: numeric strings converted to integers in cursorTo#13271petekeller2 wants to merge 2 commits intonodejs:masterfrom
petekeller2 wants to merge 2 commits intonodejs:masterfrom
Conversation
Contributor
|
Why would we want to support this? I would consider passing non-number values to be an error. |
Author
|
To make cursorTo easier to work with. A variable equal to a numeric string might be passed in by mistake. An error message for this case might be better though. |
Contributor
|
I think throwing would be better than interpreting strings in this case. |
Member
|
I'm not a big fan of this approach either. I'm +1 on just throwing a TypeError if the input is not a number already. |
Author
|
I'll close this one since there are a lot of open pull requests |
This was referenced Jun 21, 2023
This was referenced Jun 22, 2023
This was referenced Jun 22, 2023
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to convert x and y in cursorTo to integers if they are not of type number
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
readline