doc: add jasongin & kunalspathak to collaborators#13200
Closed
jasongin wants to merge 1 commit intonodejs:masterfrom
Closed
doc: add jasongin & kunalspathak to collaborators#13200jasongin wants to merge 1 commit intonodejs:masterfrom
jasongin wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
May 24, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM. I don't know what happened in the training, but usually this would be two PRs by the people being added.
jasongin
force-pushed
the
add-collaborators
branch
from
685ec4f to
55cad82
Compare
jasongin
changed the title
addaleax
approved these changes
May 24, 2017
Fishrock123
approved these changes
May 24, 2017
Contributor
Fishrock123
left a comment
Fishrock123
left a comment
There was a problem hiding this comment.
LGTM. Both from the same computer is a new one! :D
aqrln
approved these changes
May 24, 2017
Member
|
@cjihrig The two of them are sharing a computer, that’s why. :) |
Member
|
Welcome :) |
Member
Author
|
Landed as f5df94b |
jasongin
added a commit
that referenced
this pull request
May 24, 2017
PR-URL: #13200 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Contributor
|
Welcome 🎆 |
jasnell
pushed a commit
that referenced
this pull request
May 25, 2017
PR-URL: #13200 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
PR-URL: #13200 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
PR-URL: #13200 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for onboarding us @addaleax !
Checklist
Affected core subsystem(s)
doc