async_hooks: rename AsyncEvent to AsyncResource#13192
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
async_hooks: rename AsyncEvent to AsyncResource#13192addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
`AsyncEvent` is not a good name given its semantics.
addaleax
added
async_hooks
nodejs-github-bot
added
the
async_hooks
4 tasks
AndreasMadsen
approved these changes
May 24, 2017
Member
AndreasMadsen
left a comment
AndreasMadsen
left a comment
There was a problem hiding this comment.
LGTM if the CI is green.
cjihrig
approved these changes
May 24, 2017
jasnell
approved these changes
May 24, 2017
Member
Author
|
Landed in 90dee89 |
addaleax
added a commit
that referenced
this pull request
May 26, 2017
`AsyncEvent` is not a good name given its semantics. PR-URL: #13192 Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
`AsyncEvent` is not a good name given its semantics. PR-URL: #13192 Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncEventis not a good name given its semantics.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
async_hooks