test: refactor event-emitter-check-listener-leaks#13164
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: refactor event-emitter-check-listener-leaks#13164Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
* add block-scoping * use common.mustCall() on callbacks that should not execute
Trott
added
events
jasnell
approved these changes
May 23, 2017
refack
approved these changes
May 23, 2017
Contributor
|
Since github does such a bad job of comparing this, here's an export from BeyondCompare4: |
Member
Author
|
@refack GitHub provides a much more usable diff if you pass (And if you already knew that, consider it a notification for other readers who might be unaware.) |
Contributor
|
😲 |
lpinca
approved these changes
May 23, 2017
cjihrig
approved these changes
May 23, 2017
Member
Author
Member
Author
|
Landed in 16357f2 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 25, 2017
* add block-scoping * use common.mustCall() on callbacks that should not execute PR-URL: nodejs#13164 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
* add block-scoping * use common.mustCall() on callbacks that should not execute PR-URL: #13164 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
Contributor
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
This was referenced Jun 21, 2023
This was referenced Jun 22, 2023
This was referenced Jun 22, 2023
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test events