doc: don't use useless constructors in stream.md#13145
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:stream-no-useless-constructor
Closed
doc: don't use useless constructors in stream.md#13145vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:stream-no-useless-constructor
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:stream-no-useless-constructor
Conversation
vsemozhetbyt
added
doc
nodejs-github-bot
added
doc
danbev
approved these changes
May 22, 2017
cjihrig
approved these changes
May 22, 2017
jasnell
approved these changes
May 22, 2017
Contributor
Author
|
Landed in 6af72d4 |
vsemozhetbyt
added a commit
that referenced
this pull request
May 24, 2017
PR-URL: #13145 Refs: http://eslint.org/docs/rules/no-useless-constructor Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 24, 2017
PR-URL: #13145 Refs: http://eslint.org/docs/rules/no-useless-constructor Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
PR-URL: #13145 Refs: http://eslint.org/docs/rules/no-useless-constructor Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
PR-URL: #13145 Refs: http://eslint.org/docs/rules/no-useless-constructor Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jun 21, 2023
This was referenced Jun 22, 2023
This was referenced Jun 22, 2023
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, stream
Refs: http://eslint.org/docs/rules/no-useless-constructor
The constructors in these fragments could be completely removed to eliminate useless constructor promotion, but this would make the examples a bit bare, so I've decided to just add ellipses to hint at an extension of code.