url: expose WHATWG url.origin as ASCII#13126
Closed
TimothyGu wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
dont-land-on-v4.x
whatwg-url
refack
approved these changes
May 20, 2017
| const unicodeHost = unicode ? domainToUnicode(host) : host; | ||
| return `${scheme}//${unicodeHost}${port === null ? '' : `:${port}`}`; | ||
| // Refs: https://html.spec.whatwg.org/multipage/browsers.html#ascii-serialisation-of-an-origin | ||
| function serializeTupleOrigin(scheme, host, port) { |
Contributor
There was a problem hiding this comment.
Maybe keep https://html.spec.whatwg.org/multipage/browsers.html#unicode-serialisation-of-an-origin or quote the Note: There used to also be a Unicode serialization of an origin. However, it was never widely adopted.
Member
Author
There was a problem hiding this comment.
Is there a need to? This function is purely internal, and there is no remnant from the previous Unicode serialization that needs explanation.
Contributor
There was a problem hiding this comment.
Since the standard kept a "there was something here", I thought we could emulate.
But I yield to your decision.
jasnell
approved these changes
May 20, 2017
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
Lgtm. This part was always a bit sketchy to me since I knew browsers weren't consistent. Glad to see this fixed
watilde
approved these changes
May 20, 2017
joyeecheung
approved these changes
May 22, 2017
Member
Member
Author
|
Landed in 413691f. |
TimothyGu
added a commit
that referenced
this pull request
May 25, 2017
PR-URL: #13126 Refs: whatwg/url#297 Refs: web-platform-tests/wpt#5944 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 25, 2017
PR-URL: #13126 Refs: whatwg/url#297 Refs: web-platform-tests/wpt#5944 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
PR-URL: #13126 Refs: whatwg/url#297 Refs: web-platform-tests/wpt#5944 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
TimothyGu
added a commit
to TimothyGu/node
that referenced
this pull request
Jul 25, 2017
Fixes: 413691f "url: expose WHATWG url.origin as ASCII" Refs: nodejs#13126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: whatwg/url#297
Refs: web-platform-tests/wpt#5944
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url