src: remove unnecessary return statement#13094
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
I think the code would be a little clearer if the return statement was removed here since End() does not return any value and neither does ParseHeader.
nodejs-github-bot
added
c++
Contributor
Author
bnoordhuis
approved these changes
May 18, 2017
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Virtual shrug. Seems clear enough to me but LGTM if you think this is better.
thefourtheye
approved these changes
May 18, 2017
Contributor
thefourtheye
left a comment
thefourtheye
left a comment
There was a problem hiding this comment.
Same as @bnoordhuis's comment.
Contributor
Author
|
@bnoordhuis @thefourtheye I'll leave this open today and if others feel the same way as you both do (or there are no more comments/approvals) I'll close this and leave it as is. |
cjihrig
approved these changes
May 18, 2017
refack
approved these changes
May 18, 2017
addaleax
approved these changes
May 18, 2017
gibfahn
approved these changes
May 18, 2017
danbev
added a commit
to danbev/node
that referenced
this pull request
May 22, 2017
I think the code would be a little clearer if the return statement was removed here since End() does not return any value and neither does ParseHeader. PR-URL: nodejs#13094 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Contributor
Author
|
Landed in 762b035 |
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
I think the code would be a little clearer if the return statement was removed here since End() does not return any value and neither does ParseHeader. PR-URL: #13094 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
I think the code would be a little clearer if the return statement was removed here since End() does not return any value and neither does ParseHeader. PR-URL: #13094 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the code would be a little clearer if the return statement
was removed here since End() does not return any value and neither
does ParseHeader.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src, crypto