test: detect all types of aborts in windows by gireeshpunathil · Pull Request #12856 · nodejs/node

gireeshpunathil · 2017-05-05T11:47:48Z

On Windows, 'aborts' are of 2 types, depending on the context:
(i) Forced access violation, if --abort-on-uncaught-exception is on
which corresponds to exit code 3221225477 (0xC0000005)
(ii) raise(SIGABRT) or abort(), which lands up in CRT library calls
which corresponds to exit code 3

For background, please refer to #12823

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

test

addaleax · 2017-05-05T11:50:08Z

It looks like this already needs a rebase 😄

gireeshpunathil · 2017-05-05T12:13:15Z

@addaleax - I don't know what would have caused this (branch conflict), and how to resolve it. Any pointers please?

addaleax · 2017-05-05T12:18:15Z

git fetch upstream (or whatever your remote that points to nodejs/node is called) and then git rebase upstream/master, fix whatever conflicts come up … let me know if that’s unclear, git is always tricky :)

On Windows, 'aborts' are of 2 types, depending on the context: (i) Forced access violation, if --abort-on-uncaught-exception is on which corresponds to exit code 3221225477 (0xC0000005) (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls which corresponds to exit code 3

gireeshpunathil · 2017-05-05T12:39:41Z

@addaleax - thanks! I guess I did it right.

refack · 2017-05-08T02:33:33Z

@gireeshpunathil could you write a few words about how come tests haven't been failing? And do we need a test that aborts with code 3?

gireeshpunathil · 2017-05-08T07:41:23Z

@refack -

  if (exports.isWindows) {
     expectedExitCodes = [3221225477];
+    console.log('XXX');
+    console.trace();
  }

With this change I ran the entire unit tests (python tools\test.py --mode=release) and it hit only once - the new test case I added (parallel/test-http-parser-consume).

Looks like we never have a test case which aborts in Windows either through JS process.abort(), or through C++ Assert(FALSE), or through --abort-on-uncaught-exception

If you propose I can add one.

refack · 2017-05-08T13:32:40Z

@gireeshpunathil thank you. IMHO adding a test would be great.

jasnell · 2017-05-09T20:06:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/7971/

addaleax · 2017-05-10T21:04:35Z

Lande in 6914aea

On Windows, 'aborts' are of 2 types, depending on the context: (i) Forced access violation, if --abort-on-uncaught-exception is on which corresponds to exit code 3221225477 (0xC0000005) (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls which corresponds to exit code 3 PR-URL: #12856 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

gireeshpunathil · 2017-05-11T02:34:24Z

thanks all!

refack · 2017-05-11T03:57:50Z

thanks all!

No, thank you 🥇

gibfahn · 2017-05-12T22:28:45Z

There seems to be a 6.10 branch in node now, which has 6914aea as the latest commit. Is this an accident (I guess maybe @addaleax, idk)?

arturgvieira-zz · 2017-05-12T22:39:20Z

I was having Git tech difficulties the other day. It was after my first PR got merged I believe.

addaleax · 2017-05-12T23:11:03Z

@gibfahn That wasn’t me, I just saw the ref in a git fetch upstream as a new branch myself. But anyway, I’ve deleted it now, it shouldn’t be there (maybe somebody who keeps IRC open knows why this happened?)

how could I have made a mistake without access rights I don't know

@arturgvieira You couldn’t, this is definitely not something you have caused. :) It’s not a big deal anyway.

arturgvieira-zz · 2017-05-12T23:12:00Z

@addaleax I see, thanks, I feel much better

refack · 2017-05-12T23:14:27Z

two days ago (EDT time)
[19:15] -nodejs-gh:#node-dev- [node] eugeneo created 6.10 from master (+0 new commits): https://git.io/v9MrZ

On Windows, 'aborts' are of 2 types, depending on the context: (i) Forced access violation, if --abort-on-uncaught-exception is on which corresponds to exit code 3221225477 (0xC0000005) (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls which corresponds to exit code 3 PR-URL: nodejs#12856 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

On Windows, 'aborts' are of 2 types, depending on the context: (i) Forced access violation, if --abort-on-uncaught-exception is on which corresponds to exit code 3221225477 (0xC0000005) (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls which corresponds to exit code 3 PR-URL: #12856 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label May 5, 2017

benjamingr approved these changes May 5, 2017

View reviewed changes

gireeshpunathil force-pushed the windowsabortcodes branch from 157b7b8 to bd0e41a Compare May 5, 2017 12:38

cjihrig approved these changes May 5, 2017

View reviewed changes

addaleax approved these changes May 5, 2017

View reviewed changes

gireeshpunathil mentioned this pull request May 5, 2017

http_parser: assert on incoming argument's type #12288

Closed

2 tasks

sreepurnajasti mentioned this pull request May 9, 2017

test: add a simple abort check in windows #12914

Closed

3 tasks

thefourtheye approved these changes May 9, 2017

View reviewed changes

gibfahn approved these changes May 9, 2017

View reviewed changes

jasnell approved these changes May 9, 2017

View reviewed changes

addaleax added the windows Issues and PRs related to the Windows platform. label May 10, 2017

addaleax closed this May 10, 2017

jasnell mentioned this pull request May 28, 2017

8.0.0 Release Proposal #12220

Closed

refack mentioned this pull request Jun 4, 2017

test: common.nodeProcessAborted() does not catch aborts in Windows #12823

Closed

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

gibfahn added the land-on-v6.x label Jun 20, 2017

MylesBorins mentioned this pull request Jul 18, 2017

v6.11.2 proposal #14356

Merged

Uh oh!

Conversation

gireeshpunathil commented May 5, 2017

Checklist

Affected core subsystem(s)

Uh oh!

addaleax commented May 5, 2017

Uh oh!

gireeshpunathil commented May 5, 2017

Uh oh!

addaleax commented May 5, 2017

Uh oh!

gireeshpunathil commented May 5, 2017

Uh oh!

refack commented May 8, 2017

Uh oh!

gireeshpunathil commented May 8, 2017

Uh oh!

refack commented May 8, 2017

Uh oh!

jasnell commented May 9, 2017

Uh oh!

addaleax commented May 10, 2017

Uh oh!

gireeshpunathil commented May 11, 2017

Uh oh!

refack commented May 11, 2017

Uh oh!

gibfahn commented May 12, 2017

Uh oh!

arturgvieira-zz commented May 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

addaleax commented May 12, 2017

Uh oh!

arturgvieira-zz commented May 12, 2017

Uh oh!

refack commented May 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

arturgvieira-zz commented May 12, 2017 •

edited

Loading

refack commented May 12, 2017 •

edited

Loading