Skip to content

doc: updated readFileSync in fs.md#12800

Closed
thelostone-mc wants to merge 2 commits intonodejs:masterfrom
thelostone-mc:docs
Closed

doc: updated readFileSync in fs.md#12800
thelostone-mc wants to merge 2 commits intonodejs:masterfrom
thelostone-mc:docs

Conversation

@thelostone-mc
Copy link
Contributor

@thelostone-mc thelostone-mc commented May 2, 2017 •
edited
Loading

Refs: #10962

Updated fs.md stating fs.readFileAsync is platform specific

Documents Updated:

  • doc/api/fs.md
Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 2, 2017
@thelostone-mc thelostone-mc mentioned this pull request May 2, 2017
Closed
@fhalde
Copy link
Contributor

fhalde commented May 2, 2017

prefix the PR and commit with the subsystem you changed. In this case doc
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md

refack
refack suggested changes May 2, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link
Contributor

@refack refack May 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS, Linux, and Windows
We use the Oxford comma

Copy link
Contributor

@refack refack May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move "see example below" to the last line of the paragraph

doc/api/fs.md Outdated
Copy link
Contributor

@refack refack May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove "In contrast"
  • add the - "on FreeBSD, the content"

doc/api/fs.md Outdated
Copy link
Contributor

@refack refack May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should explain which file? as it's a directory?

Copy link
Contributor Author

@thelostone-mc thelostone-mc May 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack Would that mean :
On FreeBSD, the contents of the files in the directory will be returned.

Copy link
Contributor

@refack refack May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that is what happens, then yes, exactly.
BTW: that's strange, how do you know when one file ends and another begins... 🤔

Copy link
Contributor Author

@thelostone-mc thelostone-mc May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to set up FreeBSD and check it out now 😛

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented May 2, 2017

Thank you!
Linter CI: https://ci.nodejs.org/job/node-test-linter/8726/

@refack
Copy link
Contributor

refack commented May 2, 2017

Thank you very much for the contribution 🥇
(don't take the comments too hard 😉)

@thelostone-mc
Copy link
Contributor Author

thelostone-mc commented May 2, 2017

@refack Haha!! Well next time you won't be able to point things like this out in my next PR 😎
Thanks !!

@refack
Copy link
Contributor

refack commented May 2, 2017

@refack Haha!! Well next time you won't be able to point things like this out in my next PR 😎
Thanks !!

I agree, the best way to learn is by doing!

@thelostone-mc thelostone-mc changed the title Updated fs.md for readFileSync doc: updated readFileSync in fs.md May 2, 2017
@thelostone-mc
Copy link
Contributor Author

thelostone-mc commented May 2, 2017

@fhalde Thanks !! 🕺

mscdex
mscdex reviewed May 2, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link
Contributor

@mscdex mscdex May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean exactly? Is it just all of the files concatenated together one after the other? With or without boundaries?

Copy link
Member

@jasnell jasnell May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been working (slowly) on getting as much consistency as possible in the Note sections in the docs... Can you please make this...

*Note*: The behavior...

... and do not bold the entire paragraph.

mscdex
mscdex reviewed May 2, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link
Contributor

@mscdex mscdex May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synchronous methods don't accept callbacks.

mscdex
mscdex reviewed May 2, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link
Contributor

@mscdex mscdex May 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be more general about what functions are affected since it would also include the async counterpart as well as anyone using fs.open('/path/to/dir') with fs.read() or their sync counterparts for example.

Copy link
Contributor Author

@thelostone-mc thelostone-mc May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't the example clear this up? I agree your comment give room for less confusion
But the line below would clear up that confusion:

When the given path identifies a directory, the behavior of fs.readFile() and fs.readFileSync() is platform specific

Copy link
Contributor

@mscdex mscdex May 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except those methods both implicitly use fs.open()/fs.read(). So really the note should be above one of those instead, but many people use readFile() as well. That is why I suggested possibly putting the note for both readFile() and fs.read() (and their sync counterparts).

jasnell
jasnell requested changes May 2, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link
Member

@jasnell jasnell May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been working (slowly) on getting as much consistency as possible in the Note sections in the docs... Can you please make this...

*Note*: The behavior...

... and do not bold the entire paragraph.

doc/api/fs.md Outdated
Copy link
Member

@jasnell jasnell May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this first line...

When the given path identifies a directory, the behavior of `fs.readFile()` and
`fs.readFileSync()` is platform specific. On macOS, Linux and Windows, an
error will be returned. On FreeBSD...

Copy link
Contributor Author

@thelostone-mc thelostone-mc May 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell If i were to do this, this would be first line fs.readFile().
Would we need the same to be copied even for fs.readFileSync() ?
Also , would I be giving examples for both sync and async counterparts ?

@thelostone-mc thelostone-mc force-pushed the docs branch 2 times, most recently from e358d43 to 338bc1b Compare May 2, 2017 22:32
Trott
Trott reviewed May 3, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link
Member

@Trott Trott May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: platform specific -> platform-specific

Copy link
Member

@Trott Trott May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Although I know you didn't write that text. But while we're here...)

Copy link
Contributor Author

@thelostone-mc thelostone-mc May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider it done.

Trott
Trott reviewed May 3, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link
Member

@Trott Trott May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: platform specific -> platform-specific

Copy link
Member

@Trott Trott May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put a space after the period.

Copy link
Member

@Trott Trott May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma after Linux please.

Copy link
Contributor Author

@thelostone-mc thelostone-mc May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott comma after Linux instead of and. Are you sure about that?

Copy link
Member

@Trott Trott May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityaanandmc Comma after Linux and keep the and:

On macOs, Linux, and Windows, an error will be returned.

That would be a serial comma and be in accordance with the style guide for Node.js docs.

Copy link
Contributor Author

@thelostone-mc thelostone-mc May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott Haha yeah !! @refack had pointed that out! 😅

Trott
Trott reviewed May 3, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link
Member

@Trott Trott May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to say in the directory rather than in directory?

Trott
Trott reviewed May 3, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link
Member

@Trott Trott May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be too imprecise to say When the path is a directory instead of When the given path identifies a directory? The former seems clearer to me, even if the latter may be more precise.

Copy link
Contributor Author

@thelostone-mc thelostone-mc May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Will change it

Trott
Trott reviewed May 3, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a bunch of small comments, although most of them probably shouldn't stop this from landing if the contributor is exhausted from requests for small changes. :-D (Also, whoever lands it can probably fix any of them that are important.)

@mscdex
Copy link
Contributor

mscdex commented May 3, 2017

I think a similar note should be made above fs.read()/fs.readSync() for file descriptors for directories.

@thelostone-mc
Copy link
Contributor Author

thelostone-mc commented May 3, 2017

@Trott Looked into the comments and changes everything accordingly except the

Comma after Linux please.

Well, any number of small fixes -> still worth it for documentation, so it's alright!

@thelostone-mc thelostone-mc force-pushed the docs branch 2 times, most recently from 4933ce0 to b4e42e0 Compare May 3, 2017 07:19
refack
refack suggested changes May 3, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link
Contributor

@refack refack May 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott is not just being picky. It's called the "oxford comma" and we ask for its use in our style guide

Copy link
Contributor Author

@thelostone-mc thelostone-mc May 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack
Did not see that! Got it. Fixed!
@Trott Sorry about that!! Didn't see the guide

Question: [`fs.readFileSync()`][]
Is this the right way to link this to the title fs.readFileSync() ?
Doesn't seem to be working.

Copy link
Contributor

@refack refack May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be... It doesn't work in the GitHub web view but will work in https://nodejs.org/api/fs.html#fs_fs_readfilesync_file_options

s0m3on3
s0m3on3 reviewed May 4, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link

@s0m3on3 s0m3on3 May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just <data> ?

doc/api/fs.md Outdated
Copy link

@s0m3on3 s0m3on3 May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ mkdir test && echo hello > test/1 && echo world > test/2
$ node -p "fs.readFileSync('test')"
<Buffer 03 00 00 00>
$ node -p "fs.readFileSync('/tmp')"
<Buffer 03 00 00 00 00 00 00>

Doesn't look like the contents 😄
FreeBSD 11

Copy link
Contributor Author

@thelostone-mc thelostone-mc May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s0m3on3 Have look at the options parameter in the doc, you can pass the encoding format as "utf-8" to get the contents in a readable format.

If no encoding is specified, then the raw buffer is returned.

Copy link

@s0m3on3 s0m3on3 May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This buffer doesn't look like a readable utf8 string too

Copy link
Contributor Author

@thelostone-mc thelostone-mc May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try it with : node -p "fs.readFileSync('test', 'utf-8')"

I'm on MacOS, so I tried it with fs.readFileSync() on a file instead of a directory and it worked as expected!

Copy link

@s0m3on3 s0m3on3 May 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityaanandmc No problem

$ node -p "fs.readFileSync('test', 'utf-8')"
�

The same as

Buffer.from([3, 0, 0, 0]).toString("utf-8")

What did you expect ? 😃
Yes, macOS works as expected(throws an error), but the subject is FreeBSD, and "test" is a directory.

On FreeBSD, the contents of the files in the directory will be returned.

This is wrong.
Linux(Darwin too) doesn't allow using the read syscall to read bytes from a directory, but FreeBSD does 😐
And the result doesn't look like the contents of the files in the directory

Copy link
Contributor

@refack refack May 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s0m3on3 so what are those?

$ node -p "fs.readFileSync('test')"
<Buffer 03 00 00 00>
$ node -p "fs.readFileSync('/tmp')"
<Buffer 03 00 00 00 00 00 00>

Copy link

@s0m3on3 s0m3on3 May 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack I don't know. The directory contents as a file, some internal structure

Copy link
Contributor

@refack refack May 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:
On FreeBSD, a representation of the directory's contents will be returned.

@refack
Copy link
Contributor

refack commented May 5, 2017

I spun up a freeBSD vm and got this:

> fs.readFileSync('test', {encoding:'utf-8'}).replace('\u0000', ' ')
'�M\u0005 \f\u0000\u0004\u0001.\u0000\u0000\u0000\u0006�\u0004\u0000\f\u0000\u0004\u0002..\u0000\u0000�M\u0005\u0000\u001c\u0000\u0004\u0013this_is_a_directory\u0000D�\u0004\u0000\u0010\u0000\b\u0005hello\u0000��N�\u0004\u0000�\u0001\b\bduck.txt\u0000\u0001v�\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000'
> fs.readFileSync('test', {encoding:'utf-8'}).replace(/\u0000/g, ' ')
'�M\u0005 \f \u0004\u0001.   \u0006�\u0004 \f \u0004\u0002..  �M\u0005 \u001c \u0004\u0013this_is_a_directory D�\u0004 \u0010 \b\u0005hello ��N�\u0004 �\u0001\b\bduck.txt \u0001v�                                                                                                                                                                                                                                                                                                                                                                                                                                        '
> fs.readdirSync('test')
[ 'duck.txt', 'hello', 'this_is_a_directory' ]
>

So IMHO we should say:
On FreeBSD, a representation of the directory's contents will be returned.

refack
refack suggested changes May 5, 2017
View reviewed changes
doc/api/fs.md Outdated
Copy link
Contributor

@refack refack May 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:
On FreeBSD, a representation of the directory's contents will be returned.

@thelostone-mc
doc: updated readFileSync in fs.md
bd37c00 
Updated fs.md stating fs.readFileAsync is platform specific

Refs: nodejs#10962
@thelostone-mc
Copy link
Contributor Author

thelostone-mc commented May 5, 2017

@refack Done!!

refack pushed a commit that referenced this pull request May 5, 2017
@thelostone-mc @refack
doc: update readFileSync in fs.md
2614d24 
* Updated fs.md stating fs.readFileAsync is platform specific
* Fix formatting of `note`s

PR-URL: #12800
Refs: #10962
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@refack
Copy link
Contributor

refack commented May 5, 2017

Landed in: 2614d24

@refack refack closed this May 5, 2017
@refack
Copy link
Contributor

refack commented May 5, 2017

Post land CI (Just lint): https://ci.nodejs.org/job/node-test-linter/8838/

anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
@thelostone-mc
doc: update readFileSync in fs.md
5f2b8a3 
* Updated fs.md stating fs.readFileAsync is platform specific
* Fix formatting of `note`s

PR-URL: nodejs#12800
Refs: nodejs#10962
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@thelostone-mc thelostone-mc deleted the docs branch May 7, 2017 05:24
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 18, 2017
@thelostone-mc @gibfahn
doc: update readFileSync in fs.md
5b979a8 
* Updated fs.md stating fs.readFileAsync is platform specific
* Fix formatting of `note`s

PR-URL: #12800
Refs: #10962
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@thelostone-mc @gibfahn
doc: update readFileSync in fs.md
242f6a7 
* Updated fs.md stating fs.readFileAsync is platform specific
* Fix formatting of `note`s

PR-URL: #12800
Refs: #10962
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@thelostone-mc @MylesBorins
doc: update readFileSync in fs.md
3b1d911 
* Updated fs.md stating fs.readFileAsync is platform specific
* Fix formatting of `note`s

PR-URL: #12800
Refs: #10962
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott left review comments

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

+3 more reviewers

@mscdex mscdex mscdex left review comments

@s0m3on3 s0m3on3 s0m3on3 left review comments

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.