vcbuild.bat: adding option static enabling the option --enable-static#12764
Closed
TonyRice wants to merge 1 commit intonodejs:masterfrom
TonyRice:master
Closed
vcbuild.bat: adding option static enabling the option --enable-static#12764TonyRice wants to merge 1 commit intonodejs:masterfrom TonyRice:master
TonyRice wants to merge 1 commit intonodejs:masterfrom
TonyRice:master
Conversation
nodejs-github-bot
added
build
addaleax
approved these changes
Apr 30, 2017
Member
|
@nodejs/platform-windows |
refack
approved these changes
Apr 30, 2017
Contributor
|
@TonyRice I edited the first comment. Removed a space so the checklist will be formatted correctly. |
Member
|
Please could you format your commit message according to the Contributing Guidelines? Maybe something like this? If you don't have time it can be rewritten by whoever lands this, but if you are going to help out more on the project (as I hope you do), then it saves work if you produce better commit messages. |
gibfahn
approved these changes
Apr 30, 2017
Member
gibfahn
left a comment
gibfahn
left a comment
There was a problem hiding this comment.
LGTM I guess, though having to duplicate every configure option because we're running it inside vcbuild.bat seems pretty backwards.
Contributor
Member
addaleax
pushed a commit
that referenced
this pull request
May 3, 2017
Passes --enable-static to ./configure. PR-URL: #12764 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
Passes --enable-static to ./configure. PR-URL: nodejs#12764 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
3 tasks
gibfahn
pushed a commit
that referenced
this pull request
Jun 18, 2017
Passes --enable-static to ./configure. PR-URL: #12764 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
Passes --enable-static to ./configure. PR-URL: #12764 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
Passes --enable-static to ./configure. PR-URL: #12764 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply adds a new (static) option within vcbuild.bat that allows you to easily add the --enable-static option to the visual studio build.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes