test: changes to test/parallel/test-querystring.js

[lukaszewczak]

Change URIError constructor to regular expression in assert.throws and use block-scope for tests that spans multiple statements

Checklist

• [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
• [x ] commit message follows commit guidelines

Affected core subsystem(s)

test

[vsemozhetbyt]

CI: https://ci.nodejs.org/job/node-test-pull-request/7686/

[lpinca]

There are a lot of whitespace changes in the diff which can be ignored appending ?w=1 to the URL.
Hope this helps other reviewers who may not know this handy trick.

[lukaszewczak]

Hi, this error during test/windows-frame build is quite strange for me, and looks like some temporary connectivity issue, not related to my changes...? Could you please run once again this build process.

java.nio.channels.ClosedChannelException
	at org.jenkinsci.remoting.protocol.NetworkLayer.onRecvClosed(NetworkLayer.java:154)
	at org.jenkinsci.remoting.protocol.impl.NIONetworkLayer.ready(NIONetworkLayer.java:179)
	at org.jenkinsci.remoting.protocol.IOHub$OnReady.run(IOHub.java:721)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused: java.io.IOException: Backing channel 'JNLP4-connect connection from 104.130.175.153/104.130.175.153:49164' is disconnected.

[addaleax]

@lukaszewczak That’s just the CI infrastructure being a bit problematic sometimes, don’t worry about it. :)

[lukaszewczak]

Uff :-) Thank you @addaleax for quick replay.

[addaleax]

Landed in 42958d1 and fixed up linter errors while landing, thanks for the PR!