Merged
Conversation
nodejs-github-bot
added
the
npm
Contributor
Author
|
I can confirm this appears to fix a related issue with GitHub for Mac for me. |
Contributor
|
I don't know how I can test this till landing: I only had problems with unpacking GH zips with the repo. Should I try to download a zip from https://github.com/nodejs/node/tree/Fishrock123-remove-badly-cased-file ? |
Contributor
|
Can confirm: https://github.com/nodejs/node/archive/Fishrock123-remove-badly-cased-file.zip contains no duplicates and is unpacked without a break. Thank you! |
vsemozhetbyt
approved these changes
Apr 25, 2017
jasnell
approved these changes
Apr 25, 2017
TimothyGu
approved these changes
Apr 25, 2017
cjihrig
approved these changes
Apr 25, 2017
aqrln
approved these changes
Apr 26, 2017
thefourtheye
approved these changes
Apr 26, 2017
Fishrock123
force-pushed
the
Fishrock123-remove-badly-cased-file
branch
from
5bd9c45 to
d3447f7
Compare
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fishrock123
force-pushed
the
Fishrock123-remove-badly-cased-file
branch
from
d3447f7 to
e8f3163
Compare
Contributor
|
Refs: #12680 |
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
Having multiple files with the same name but different casings causes problems on lots of OS-s. Refs: #12624 Refs: #11085 Refs: #11020 PR-URL: #12643 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having multiples of the same file name with different casings causes problems on lots of OS-s.
Refs: #12624
@vsemozhetbyt think you could check if this fixed the issue for you?
Apologies if this commit is weird, I had to make it in the GitHub GUI.
Checklist
Affected core subsystem(s)
deps