test: dynamic port in parallel regress tests#12639
test: dynamic port in parallel regress tests#12639sebastianplesciuc wants to merge 1 commit intonodejs:masterfrom sebastianplesciuc:common-port-parallel-regress
Conversation
|
For test/parallel/test-regress-GH-5051.js, do we actually need to do all this? It creates a request but it never actually runs the request, does it? (Honest question; I'm actually not sure.) If it never tries to connect to a port or anything, then we can just hard-code it to |
Trott
left a comment
There was a problem hiding this comment.
I'm pretty sure the 5051 test never actually runs a network request, so we can dispense with net and hardcode any port we like. (I propose 8080.) If you believe differently, by all means, fill me in.
|
@Trott You're right. I changed it to 8080 and fixed the |
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI is green. Might want to consider adding a comment where 8080 is being hardcoded explaining that there's no network connection that actually happens; it's a request that gets created but never used. But I'm fine with it as-is too.
|
@Trott Added comment :) |
|
Landed in e927809, thanks for the PR! |
Removed common.PORT from test-regress-GH-5051 and
test-regress-GH-5727 in order to eliminate the possibility
of port collision.
Refs: #12376
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test