Conversation
This will allow `localAddress` to be properly set before writing debug output.
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
You can move it a few lines down to line 875 to avoid the duplication and, optionally, include err in the message.
|
I figured I'd keep the original message intact since it says 'binding' instead of 'bound'. *shrug* Unless we want to have two separate messages? |
Feel free to change it. There is no backwards compatibility concern here. |
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, although I slightly prefer @bnoordhuis suggestion.
This will allow `localAddress` to be properly set before writing debug output. PR-URL: nodejs#12616 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 2154a3c. I went ahead to move the statement down as @bnoordhuis suggested. I hope that is ok. |
|
@BridgeAR If the statement was going to be moved at the very least the wording should have been changed to reflect what actually happened... |
|
@mscdex I am not sure I can follow. As far as I see it the wording still fits. |
|
@BridgeAR Since the message is now printed after |
|
Oh, of course. Sorry, I should probably not have changed that especially not without changing the wording. I guess it is to late for a force push but I can open a fix for it later. |
|
If you think it is not yet to late for a force push, maybe you could just do that right quick? I will be afk for a while. |
This will allow `localAddress` to be properly set before writing debug output. PR-URL: nodejs/node#12616 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This will allow `localAddress` to be properly set before writing debug output. PR-URL: nodejs/node#12616 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This will allow `localAddress` to be properly set before writing debug output. PR-URL: #12616 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This will allow `localAddress` to be properly set before writing debug output. PR-URL: #12616 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Should this be backported to |
8 participants
This will allow
localAddressto be properly set before writing debug output./cc @bnoordhuis
CI: https://ci.nodejs.org/job/node-test-pull-request/7631/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)