test: improve test-process-chdir

[vperezma]

remove typeError constructor and replace with regex string to match typeError message

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test

[vsemozhetbyt]

CI: https://ci.nodejs.org/job/node-test-pull-request/7589/

[addaleax]

If you want, I’d say you can also remove the 'Bad argument.' parameters, the error message check should be enough :)

Looks good either way, though.

[Trott]

LGTM if CI is green. Agree with @addaleax that the third argument can optionally be removed (here or in a subsequent PR).

[jasnell]

LGTM. This could be improved slightly by defining the regex once...

const errCheck = /^TypeError: Bad argument$/;
// ...
assert.throws(() => {}, errCheck);
assert.throws(() => {}, errCheck);

[jasnell]

Landed in b968d58. Thank you!