test: improve test-process-kill-pid#12588
Closed
StephQuery wants to merge 2 commits intonodejs:masterfrom
StephQuery:master
Closed
test: improve test-process-kill-pid#12588StephQuery wants to merge 2 commits intonodejs:masterfrom StephQuery:master
StephQuery wants to merge 2 commits intonodejs:masterfrom
StephQuery:master
Conversation
Contributor
|
I think the regexps should be more strict (e.g. adding start (^) and end ($) identifiers). |
Contributor
addaleax
added
the
code-and-learn
addaleax
approved these changes
Apr 22, 2017
Trott
approved these changes
Apr 22, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM if there are no CI surprises.
cjihrig
approved these changes
Apr 22, 2017
jasnell
approved these changes
Apr 24, 2017
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM .... This could be made slightly better by defining the regex once and reusing it..
const errCheck = /^TypeError: invalid pid$/;
// ...
assert.throws(() => {}, errCheck);
assert.throws(() => {}, errCheck);
gibfahn
approved these changes
Apr 24, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 26, 2017
PR-URL: nodejs#12588 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Member
|
Landed in 60db588. |
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
PR-URL: #12588 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12588 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12588 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
May 15, 2017
PR-URL: #12588 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#12588 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)