backport v4.x: test: fix flaky test-tls-wrap-timeout#12567
Closed
BethGriggs wants to merge 1 commit intonodejs:v4.x-stagingfrom
Closed
backport v4.x: test: fix flaky test-tls-wrap-timeout#12567BethGriggs wants to merge 1 commit intonodejs:v4.x-stagingfrom
BethGriggs wants to merge 1 commit intonodejs:v4.x-stagingfrom
Conversation
Competing timers were causing a race condition and thus the test was flaky. Instead, we check an object property on process exit. Fixes: nodejs#7650 PR-URL: nodejs#7857 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Member
|
@MylesBorins it'd be really helpful to have this land on v4.x if possible. This test is flaky, and we've seen it fail several times. I'm also not sure why it wasn't backported a while ago, as it landed in master last July. |
jasnell
approved these changes
Apr 21, 2017
Contributor
|
@gibfahn by the maintenance contract we are no longer supposed to be backporting fixes to tests. It didn't land because we have not been super adamant about making sure tests that don't land cleanly backport. Personally I'm -1 on making exceptions for tests, but willing to reconsider if @nodejs/lts thinks this should land |
This was referenced Apr 24, 2017
Member
|
@MylesBorins did you say you were going to land this, or should we close this PR? |
MylesBorins
pushed a commit
that referenced
this pull request
May 2, 2017
Competing timers were causing a race condition and thus the test was flaky. Instead, we check an object property on process exit. Fixes: #7650 Backport-PR-URL: #12567 PR-URL: #7857 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Contributor
|
landed in 6040efd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Competing timers were causing a race condition and thus the test was
flaky. Instead, we check an object property on process exit.
Fixes: #7650
PR-URL: #7857
Reviewed-By: Santiago Gimeno santiago.gimeno@gmail.com
Reviewed-By: Fedor Indutny fedor.indutny@gmail.com
Reviewed-By: jasnell - James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)