test: check that pending warning is emitted once#12527
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: check that pending warning is emitted once#12527Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Code for the new --pending-deprecation flag contains logic to make sure the deprecation warning is emitted only once. However, this was not being tested. Add test coverage for this situation.
Trott
added
buffer
lpinca
approved these changes
Apr 20, 2017
Member
danbev
approved these changes
Apr 20, 2017
cjihrig
approved these changes
Apr 20, 2017
jasnell
approved these changes
Apr 20, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 24, 2017
Code for the new --pending-deprecation flag contains logic to make sure the deprecation warning is emitted only once. However, this was not being tested. Add test coverage for this situation. PR-URL: #12527 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 75bfdad |
3 tasks
Member
|
Marking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code for the new --pending-deprecation flag contains logic to make sure
the deprecation warning is emitted only once. However, this was not
being tested. Add test coverage for this situation.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test buffer