test: add coverage for vm's breakOnSigint option#12512
Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
Closed
test: add coverage for vm's breakOnSigint option#12512cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig wants to merge 1 commit intonodejs:masterfrom
Conversation
The breakOnSigint option follows different code paths, depending on the number of listeners for SIGINT. This commit updates the existing test to vary the number of SIGINT handlers.
DavidCai1111
approved these changes
Apr 20, 2017
Member
jasnell
approved these changes
Apr 20, 2017
DavidCai1111
pushed a commit
that referenced
this pull request
Apr 21, 2017
The breakOnSigint option follows different code paths, depending on the number of listeners for SIGINT. This commit updates the existing test to vary the number of SIGINT handlers. PR-URL: #12512 Reviewed-By: David Cai <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in 4bcbefc |
Contributor
|
This is failing on v7.x-staging. Going to mark as don't land |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
breakOnSigintoption follows different code paths, depending on the number of listeners forSIGINT. This commit updates the existing test to vary the number ofSIGINThandlers.This should get code coverage on
lib/vm.jsto 100%.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test