test: add inspect-brk option to cluster module#12503
Closed
dave-k wants to merge 4 commits intonodejs:masterfrom
Closed
test: add inspect-brk option to cluster module#12503dave-k wants to merge 4 commits intonodejs:masterfrom
dave-k wants to merge 4 commits intonodejs:masterfrom
Conversation
Ensure that cluster interoperates with the --inspect-brk option. This does not test for —debug-brk. Fixes: nodejs#11420
benjamingr
approved these changes
Apr 19, 2017
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Slightly confusing way to write this - but still LGTM.
Contributor
|
It might be helpful to have the cluster worker print something or crash. Then, you can test that it doesn't happen because the worker is at a breakpoint. |
Have the cluster worker print something or crash. Then, test that it doesn't happen because the worker is at a breakpoint.
cjihrig
requested changes
Apr 19, 2017
| test([`--inspect-brk=${debuggerPort}`]); | ||
| } else { | ||
| // Cluster worker is at a breakpoint, should not reach here. | ||
| assert.fail(1, 2, 'Test failed: cluster worker is at a breakpoint.', '>'); |
Contributor
There was a problem hiding this comment.
As of recently, this can just be:
assert.fail('Test failed: cluster worker is at a breakpoint.');
Contributor
Author
|
Are the requested changes OK? |
cjihrig
approved these changes
Apr 20, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM if the CI is good. However, because this test uses common.PORT, it should probably be moved from parallel to sequential.
Contributor
Author
|
Can this proceed or does the test need to be moved from parallel to sequential? |
Contributor
|
I would move it to sequential as long as |
because this test uses common.PORT, moved from parallel to sequential.
Contributor
Member
|
Landed in 0324ac6 |
Member
|
Should land with #12615 if that lands |
3 tasks
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that cluster interoperates with the --inspect-brk option.
This does not test for —debug-brk.
Fixes: #11420
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test cluster