test: moved test-debugger-repeat-last.js from parallel to sequential#12470
test: moved test-debugger-repeat-last.js from parallel to sequential#12470kumarrishav wants to merge 1 commit intonodejs:masterfrom kumarrishav:changeCommonPORT
Conversation
|
It seems we have timeouts with this test now. |
There was a problem hiding this comment.
If I get it right, this could be just '--port=0' now)
There was a problem hiding this comment.
yeah. updating it now.
There was a problem hiding this comment.
Sorry, linter fails: Strings must use singlequote Could you replace backticks with singlequotes, please.
There was a problem hiding this comment.
Sorry, my fault :( . now fixed.
Tests are getting passed on my mac system
|
cc @nodejs/testing Still timeouts on Linux machines. |
There was a problem hiding this comment.
This won't work. debug cannot accept port 0 on the command line. It requires a port between 1024 and 65535.
There was a problem hiding this comment.
This might be one of those cases where the best thing to do is to move the test from parallel to sequential.
There was a problem hiding this comment.
doh! you're right. To be honest, tho, --port=0 is something that I believe should work. That's a separate change tho.
There was a problem hiding this comment.
--port=0is something that I believe should work.
See @bnoordhuis's #5025 (and briefly @sam-github's #12093).
There was a problem hiding this comment.
How should we go with this? move it sequential ?
There was a problem hiding this comment.
How should we go with this? move it sequential ?
Yeah, I think so.
kumarrishav
changed the title
|
moved the test from parallel to sequential. @Trott |
|
Lone CI failure is unrelated (and should be fixed now if you want to run CI again, but I don't think that's necessary in this case). |
PR-URL: nodejs#12470 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 200961b. |
PR-URL: #12470 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #12470 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #12470 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #12470 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #12470 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs/node#12470 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
11 participants
Refs: #12376
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test