Closed
Conversation
46f202 introduced changes that cause a previously reachable error condition to be unreachable. Remove the code. The error condition checks that `byteLength()` doesn't return -1. But that will only happen if `byteLength()` receives an encoding that is falsy. However the call to `byteLength()` is in an `else` block that is only reachable if `encoding` is a string with a length greater than 0. So `byteLength()` will never return `-1` in this situation.
Member
|
Can I see a performance benchmark? Unreachable code might sometimes have surprising effects on the performance :) |
Contributor
ghost
approved these changes
Apr 16, 2017
Member
|
I also prefer #12439 instead. |
Member
|
#12439 has landed. Closing this. Can reopen if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
46f202 introduced changes that cause a previously reachable error
condition to be unreachable. Remove the code.
The error condition checks that
byteLength()doesn't return -1. Butthat will only happen if
byteLength()receives an encoding that isfalsy. However the call to
byteLength()is in anelseblock that isonly reachable if
encodingis a string with a length greater than 0.So
byteLength()will never return-1in this situation.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
buffer