test: remove disabled test-dgram-send-error#12330
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove disabled test-dgram-send-error#12330Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
This test was disabled in 2013 because it spams random IPs with UDP messages. We've been doing fine for four years without so let's delete it.
Trott
added
dgram
Member
Author
|
/cc @bnoordhuis I suppose this test can be rewritten to be a better net citizen. But I'm not sure it's worth it. The code base has no doubt evolved considerably in the last four years. I did spend a little time trying to rewrite it using IPv6 black-holing but couldn't get it to work. If there's concern about deleting it, a compromise could be to delete it and open an issue in the issue tracker describing the desired test and labeling it |
bnoordhuis
approved these changes
Apr 11, 2017
jasnell
approved these changes
Apr 11, 2017
richardlau
approved these changes
Apr 11, 2017
santigimeno
approved these changes
Apr 11, 2017
cjihrig
approved these changes
Apr 11, 2017
Member
Author
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 13, 2017
This test was disabled in 2013 because it spams random IPs with UDP messages. We've been doing fine for four years without so let's delete it. PR-URL: nodejs#12330 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in 3900cf6 |
3 tasks
gibfahn
pushed a commit
that referenced
this pull request
Jun 18, 2017
This test was disabled in 2013 because it spams random IPs with UDP messages. We've been doing fine for four years without so let's delete it. PR-URL: #12330 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
This test was disabled in 2013 because it spams random IPs with UDP messages. We've been doing fine for four years without so let's delete it. PR-URL: #12330 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
This test was disabled in 2013 because it spams random IPs with UDP messages. We've been doing fine for four years without so let's delete it. PR-URL: #12330 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was disabled in 2013 because it spams random IPs with UDP
messages. We've been doing fine for four years without so let's delete
it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test dgram