url: clean up WHATWG URL origin generation#12252
Closed
TimothyGu wants to merge 2 commits intonodejs:masterfrom
Closed
url: clean up WHATWG URL origin generation#12252TimothyGu wants to merge 2 commits intonodejs:masterfrom
TimothyGu wants to merge 2 commits intonodejs:masterfrom
Conversation
- Use ordinary properties instead of symbols/getter redirection for internal object - Use template string literals - Remove unneeded custom inspection for internal objects - Remove unneeded OpaqueOrigin class - Remove unneeded type checks
nodejs-github-bot
added
dont-land-on-v4.x
whatwg-url
Contributor
|
Perhaps |
Member
Author
|
@mscdex That was my original intent, and I tried to do that in #10955. But it was blocked by #10955 (comment) (not sure if @jasnell's opinion has changed). |
Member
|
I have since refractored the code that was using it. Simplifying should be fine. |
Member
jasnell
approved these changes
Apr 11, 2017
Member
|
Landed in aff5cc9 |
addaleax
pushed a commit
that referenced
this pull request
Apr 14, 2017
- Use ordinary properties instead of symbols/getter redirection for internal object - Use template string literals - Remove unneeded custom inspection for internal objects - Remove unneeded OpaqueOrigin class - Remove unneeded type checks PR-URL: #12252 Reviewed-By: James M Snell <[email protected]>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toString()Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url