src: add .FromJust(), fix -Wunused-result warnings#12118
Closed
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Closed
src: add .FromJust(), fix -Wunused-result warnings#12118bnoordhuis wants to merge 1 commit intonodejs:masterfrom
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Conversation
Missed while reviewing 1fde98b ("v8: expose new V8 serialization API.")
nodejs-github-bot
added
the
c++
targos
approved these changes
Mar 29, 2017
danbev
approved these changes
Mar 29, 2017
cjihrig
approved these changes
Mar 29, 2017
addaleax
approved these changes
Mar 29, 2017
jasnell
approved these changes
Mar 29, 2017
mscdex
added
lib / src
Member
|
Landed in 7c0079f |
addaleax
pushed a commit
that referenced
this pull request
Mar 31, 2017
Missed while reviewing 1fde98b ("v8: expose new V8 serialization API.") PR-URL: #12118 Refs: #11048 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed while reviewing 1fde98b ("v8: expose new V8 serialization API.")