test: improve test-vm-cached-data.js#11974
Closed
mpelekh wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
cjihrig
approved these changes
Mar 21, 2017
test/parallel/test-vm-cached-data.js
Outdated
Contributor
There was a problem hiding this comment.
If this is only used in one place, it probably doesn't need to go in a variable.
Contributor
Author
There was a problem hiding this comment.
You are right! I'll change it.
* verify error message by adding 2nd argument to throws in test-assert
jasnell
approved these changes
Mar 21, 2017
watilde
approved these changes
Mar 21, 2017
lpinca
approved these changes
Mar 23, 2017
Member
jasnell
pushed a commit
that referenced
this pull request
Mar 24, 2017
* verify error message by adding 2nd argument to throws in test-assert PR-URL: #11974 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 89d9c3f |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2017
* verify error message by adding 2nd argument to throws in test-assert PR-URL: #11974 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
* verify error message by adding 2nd argument to throws in test-assert PR-URL: #11974 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
* verify error message by adding 2nd argument to throws in test-assert PR-URL: #11974 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
* verify error message by adding 2nd argument to throws in test-assert PR-URL: nodejs/node#11974 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test