benchmark: harmonize progress bar and stderr output#11925
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:benchmark-progress
Closed
benchmark: harmonize progress bar and stderr output#11925vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:benchmark-progress
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:benchmark-progress
Conversation
Add a space for minimal readability.
Contributor
Author
joyeecheung
approved these changes
Mar 20, 2017
Member
joyeecheung
left a comment
There was a problem hiding this comment.
FWIW I think the fix is probably going to be in _common.js and compare.js, the progress bar doesn't know much about the processes.
jasnell
approved these changes
Mar 20, 2017
jasnell
pushed a commit
that referenced
this pull request
Mar 22, 2017
Add a space for minimal readability. PR-URL: #11925 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in 4b841cb |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2017
Add a space for minimal readability. PR-URL: #11925 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Contributor
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark
_benchmark_progress.jsdoes not work well with stderr output:It sticks together with error messages which throw and abort runs. See this comment for an example.
It still sticks together with error messages which do not throw and do not abort runs. At that, it starts to duplicate with each such message. For example, there is
misc/function_callwhich callsconsole.error()most of the time themiscsuite is launched. So the output is something like this:Till some drastic solution is applied, this commit just adds a space in the end of the bar for minimal readability. So the abovementioned output could be at least something like this: