src, url: WHATWG URL C++ parser cleanup by TimothyGu · Pull Request #11917 · nodejs/node

TimothyGu · 2017-03-18T17:59:46Z

Some general housekeeping for the WHATWG URL implementation.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

src, url

TimothyGu · 2017-03-18T20:21:53Z

C: https://ci.nodejs.org/job/node-test-pull-request/6914/

joyeecheung · 2017-03-21T09:46:49Z

src/node_url.cc

The scheme state handling seems to deviate quite a bit from the spec now?

That is unfortunately true. We already deviate from the spec by storing : as part of the scheme, coupled by the fact that we delegate some responsibilities to the JS layer, it's hard to follow the spec word-for-word.

As long as we're still API compliant and passing all the tests, such deviation is fine. It would be helpful, however, to document the deviations in code comments.

joyeecheung · 2017-03-21T09:57:50Z

src/node_url.cc

Better leave a handle for it...like XXX(TimothyGu):

nit: Can you just make this TODO(TimothyGu):

jasnell

Generally LGTM

jasnell · 2017-03-22T05:47:29Z

src/node_url.cc

nit: Can you just make this TODO(TimothyGu):

jasnell · 2017-03-22T16:38:28Z

This will need a rebase.

TimothyGu · 2017-03-22T18:29:00Z

I'll say this is currently blocked on #11934 as it will change TERMINATED and FAILED handling.

TimothyGu · 2017-03-23T17:44:42Z

@jasnell, @joyeecheung, rebased. PTAL.

jasnell · 2017-03-23T17:48:31Z

src/node_url.cc

Eventually it would likely be better just to inline this and get rid of the macro

jasnell

Generally LGTM with a couple of suggestions

jasnell · 2017-03-23T17:50:00Z

src/node_url.h

Likely worthwhile to decrement each of the remaining flags accordingly so that there's not a gap.

Fixed. I was planning on some more refactoring, but that didn't happen.

jasnell · 2017-03-27T19:22:39Z

Is this ready to go?

TimothyGu · 2017-03-27T20:13:55Z

@jasnell, go ahead with landing this if you'd like to. I've been busy the last couple of days.

jasnell · 2017-03-27T23:48:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/7066/

TimothyGu · 2017-03-30T02:59:54Z

Rebased and one last CI: https://ci.nodejs.org/job/node-test-pull-request/7099/

Do not call any completion callback with TERMINATED.

TimothyGu · 2017-03-30T05:20:37Z

Landed in 4ddd23f.

- Clarify port state - Remove scheme flag - Clarify URL_FLAG_TERMINATED PR-URL: #11917 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

italoacasas · 2017-04-10T17:54:14Z

cc @TimothyGu

TimothyGu added c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Mar 18, 2017

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Mar 18, 2017

TimothyGu force-pushed the url-cleanup branch from f3f38ab to 8325018 Compare March 19, 2017 03:49

joyeecheung reviewed Mar 21, 2017

View reviewed changes

jasnell self-assigned this Mar 21, 2017

jasnell approved these changes Mar 22, 2017

View reviewed changes

src/node_url.cc Outdated

Copy link

Member

jasnell Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can you just make this TODO(TimothyGu):

TimothyGu added the blocked PRs that are blocked by other issues or PRs. label Mar 22, 2017

TimothyGu force-pushed the url-cleanup branch from 8325018 to 9db023f Compare March 22, 2017 18:29

TimothyGu removed the blocked PRs that are blocked by other issues or PRs. label Mar 23, 2017

TimothyGu force-pushed the url-cleanup branch from 9db023f to 40320a0 Compare March 23, 2017 17:16

jasnell reviewed Mar 23, 2017

View reviewed changes

jasnell approved these changes Mar 23, 2017

View reviewed changes

TimothyGu force-pushed the url-cleanup branch from 40320a0 to 87ac590 Compare March 23, 2017 19:20

joyeecheung approved these changes Mar 24, 2017

View reviewed changes

jasnell added this to the 8.0.0 milestone Mar 27, 2017

TimothyGu force-pushed the url-cleanup branch from 0d357b4 to 63d9db3 Compare March 30, 2017 02:59

TimothyGu added 2 commits March 29, 2017 21:39

src, url: clarify port state

86d0a4b

src, url: remove scheme flag

863aa02

src, url: clarify URL_FLAG_TERMINATED

9e9dfe2

Do not call any completion callback with TERMINATED.

TimothyGu force-pushed the url-cleanup branch from 63d9db3 to 9e9dfe2 Compare March 30, 2017 05:18

TimothyGu closed this Mar 30, 2017

TimothyGu deleted the url-cleanup branch March 30, 2017 05:20

jasnell mentioned this pull request Apr 4, 2017

8.0.0 Release Proposal #12220

Closed

italoacasas added the backport-to-v7.x label Apr 10, 2017

TimothyGu mentioned this pull request Apr 19, 2017

(v7.x backport) url: updates to the WHATWG URL parser #12507

Merged

4 tasks

TimothyGu added backported-to-v7.x and removed backport-requested-v7.x labels Apr 27, 2017

Uh oh!

Conversation

TimothyGu commented Mar 18, 2017

Checklist

Affected core subsystem(s)

Uh oh!

TimothyGu commented Mar 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell commented Mar 22, 2017

Uh oh!

TimothyGu commented Mar 22, 2017

Uh oh!

TimothyGu commented Mar 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell commented Mar 27, 2017

Uh oh!

TimothyGu commented Mar 27, 2017

Uh oh!

jasnell commented Mar 27, 2017

Uh oh!

TimothyGu commented Mar 30, 2017

Uh oh!

TimothyGu commented Mar 30, 2017

Uh oh!

italoacasas commented Apr 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants