repl: Empty command should be sent to eval function#11871
Closed
hybrist wants to merge 1 commit intonodejs:masterfrom
Closed
repl: Empty command should be sent to eval function#11871hybrist wants to merge 1 commit intonodejs:masterfrom
hybrist wants to merge 1 commit intonodejs:masterfrom
Conversation
This fixes a regression introduced in nodejs#6171
Contributor
Author
|
Verified against On current master, the 2nd |
2 tasks
Contributor
Contributor
Author
|
🍏 |
addaleax
approved these changes
Mar 15, 2017
|
|
||
| process.on('exit', () => { | ||
| assert(evalCalledWithExpectedArgs); | ||
| }); |
Member
There was a problem hiding this comment.
I think you don’t need for the process to exit, the eval callback should be called synchronousl
Contributor
Author
There was a problem hiding this comment.
I can simplify the test file, just wrote it this way to match the existing ones (cp test/parallel/test-repl-{eval,empty}.js).
jasnell
approved these changes
Mar 15, 2017
cjihrig
approved these changes
Mar 16, 2017
jasnell
pushed a commit
that referenced
this pull request
Mar 17, 2017
This fixes a regression introduced in #6171 PR-URL: #11871 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
Member
|
Depends on a prior semver-major commit. Marking do-not-land on lower versions. |
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Mar 20, 2017
The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.
Ref: nodejs#11871
3 tasks
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
This fixes a regression introduced in nodejs#6171 PR-URL: nodejs#11871 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 22, 2017
The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.
PR-URL: #11946
Ref: #11871
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #6171
The command line debugger relies on the previous behavior. This adds a regression test and restores it.
Checklist
make -j4 testpassesAffected core subsystem(s)
repl