test: failing behaviour on sandboxed Proxy

[AnnaMag]

CopyProperties() causes sandboxed Proxy to throw error
despite no code being run. The CopyProperties() function
will be removed shortly with the updates to the V8 API.

Here, failing Proxy test case is moved to known_issues.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test

[AnnaMag]

cc/ @fhinkel

[fhinkel]

I agree, that proxy should not throw. The fact that it does, is an implementation detail and should be a known issue rather than a test case.

[fhinkel]

CI https://ci.nodejs.org/job/node-test-pull-request/6684/

[fhinkel]

Can you address the linter issues:

node/test/known_issues/test-vm-proxy-failure-CP.js
   4:7  error  'assert' is assigned a value but never used   no-unused-vars
  13:3  error  Expected indentation of 0 spaces but found 2  indent

Thank you!

[AnnaMag]

Done, @fhinkel

[fhinkel]

CI again: https://ci.nodejs.org/job/node-test-pull-request/6724/

[jasnell]

Unrelated failure in CI

[fhinkel]

Can you add an assert? I'd be nice to move this file from known_issue to test once the issue is addressed, and a test without an assert would be confusing.

[AnnaMag]

Great idea. Done & thanks!

[fhinkel]

Don't we expect this to not throw?

We usually have an assert in the known issues, that asserts the correct behavior but is currently failing. So for this test, we want runInContext to not throw, but it currently does.

[AnnaMag]

Yes, true. We should be able to move it from /known_issues as is. Thanks!

[fhinkel]

You're testing that the exception's error matches Sandbox throws..., which of course it doesn't because it is whoops. So the assert fails and it looks like the known issue passes. But we need to check that no exception is thrown, not that a made-up exception is not thrown.

Why don't we change the assert to
assert.doesNotThrow(() => vm.runInContext('', context));
and add a comment in the beginning of the test:
// Sandbox throws in CopyProperties() despite no code being run.

[AnnaMag]

Done. Thanks so much for pointing it out.

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/6848/

[jasnell]

Opened a tracking issue for the known-issue: #11902

[jasnell]

Landed in 6473737