test: add script to create 0-dns-cert.pem#11579
Closed
shigeki wants to merge 3 commits intonodejs:masterfrom
Closed
test: add script to create 0-dns-cert.pem#11579shigeki wants to merge 3 commits intonodejs:masterfrom
shigeki wants to merge 3 commits intonodejs:masterfrom
Conversation
0-dns-cert.pem and 0-dns-key.pem were stored in `test/fixtures/key` directory, but the cert file cannot be created with the openssl command via Makefile. Added a script to create it with using `asn1.js` and `asn1.js-rfc5280` and moved them out of key directory and put into `test/fixtures/0-dns`. The domains listed in the cert were also changed into example.com and example.org to show the use for only testing.
Contributor
Author
|
CI is running on https://ci.nodejs.org/job/node-test-pull-request/6602/ . |
Contributor
Author
|
To be the fix of #10228. |
jasnell
approved these changes
Feb 27, 2017
Contributor
Author
|
The ci jobs was somehow removed. |
sam-github
suggested changes
Feb 28, 2017
test/fixtures/0-dns/README.md
Outdated
|
|
||
| $ node ./createCert.js | ||
| $ openssl x509 -text -in 0-dns-cert.pem | ||
| (You can not see evel.example.com in subjectAltName field) |
test/fixtures/0-dns/createCert.js
Outdated
|
|
||
| const private_key = fs.readFileSync('./0-dns-key.pem'); | ||
| // public key file can be generated from the private key with | ||
| // openssl rsa -in 0-dns-key.pem -RSAPublicKey_out -outform der \ |
Contributor
There was a problem hiding this comment.
you can wrap to 80 columns, and the backslash isn't necessary at end of line
test/fixtures/0-dns/createCert.js
Outdated
| const crypto = require('crypto'); | ||
| const rfc5280 = require('asn1.js-rfc5280'); | ||
| const asn1 = require('asn1.js'); | ||
| const BN = asn1.bignum; |
test/fixtures/0-dns/createCert.js
Outdated
| @@ -0,0 +1,75 @@ | |||
| 'use strict'; | |||
Contributor
There was a problem hiding this comment.
js files would be named create-cert.js
test/fixtures/0-dns/createCert.js
Outdated
| const asn1 = require('asn1.js'); | ||
| const BN = asn1.bignum; | ||
|
|
||
| const id_at_commonName = [ 2, 5, 4, 3 ]; |
Contributor
There was a problem hiding this comment.
inconsistent casing, sometimes snake_case, sometimes camelCase, it looks like test/fixtures doesn't get linted
Contributor
Author
There was a problem hiding this comment.
id_at_commonName is named after the ASN.1 notation in RFC5280 which would come from OID name.
test/fixtures/0-dns/createCert.js
Outdated
| const subject = PrintStr.encode('evil.example.com', 'der'); | ||
|
|
||
| const tbs = | ||
| { version: 'v3', |
Contributor
There was a problem hiding this comment.
this isn't generally how node indents object literals
test/fixtures/0-dns/createCert.js
Outdated
|
|
||
| const cert = { | ||
| tbsCertificate: tbs, | ||
| signatureAlgorithm: { algorithm: sha256WithRSAEncryption, parameters: null_}, |
Contributor
There was a problem hiding this comment.
lacking before closing } here and a couple lines onwards
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
|
|
||
| // check getPeerCertificate can properly handle '\0' for fix CVE-2009-2408 |
Contributor
There was a problem hiding this comment.
Good to have a test description, it should be a capitalized and period terminated sentence.
Contributor
|
Nice use of |
shigeki
force-pushed
the
create_0-dns_cert
branch
from
0920c23 to
fd05b71
Compare
Contributor
Author
|
I made eslint for $ ./node tools/eslint/bin/eslint.js --rulesdir=tools/eslint-rules test/fixtures/0-dns/create-cert.js --no-ignore
/home/sotsu/github/node/test/fixtures/0-dns/create-cert.js
1:1 error Mandatory module "common" must be loaded required-modules
✖ 1 problem (1 error, 0 warnings)I think it is not necessary for the script in fixtures. |
sam-github
suggested changes
Mar 1, 2017
Contributor
sam-github
left a comment
sam-github
left a comment
There was a problem hiding this comment.
Its still a mixture of snake_case and camelCase for vars, but basically LGTM
test/fixtures/0-dns/0-dns-cert.pem
Outdated
| Z4CCF58oC4b7MrfFo1LXW8EdSjfK5ejFse6xZe6WNAahi7vDS7RJEyoq3EeZ4+A0 | ||
| DvrSjCuretoVAC/U7gUxs467yM3ZCujqZ4OANVQF6knRziTJEF5c1aXOzM563FT3 | ||
| ufeH36lO0ImzE+a2g6et3BZDL2PQLmBF3F6clQ== | ||
| -----END CERTIFICATE----- No newline at end of file |
Contributor
Author
|
camelCase vars are used to follow ASN.1 notation in |
Contributor
Author
|
@indutny Please take a look of this if you have time for you are the author of |
sam-github
approved these changes
Mar 2, 2017
Contributor
Author
|
I will land this tomorrow if there are no any comments. |
Contributor
Author
|
Landed in dacaaa5. Thanks. |
shigeki
added a commit
that referenced
this pull request
Mar 10, 2017
0-dns-cert.pem and 0-dns-key.pem were stored in `test/fixtures/key` directory, but the cert file cannot be created with the openssl command via Makefile. Added a script to create it with using `asn1.js` and `asn1.js-rfc5280` and moved them out of key directory and put into `test/fixtures/0-dns`. The domains listed in the cert were also changed into example.com and example.org to show the use for only testing. Fixes: #10228 PR-URL: #11579 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 13, 2017
0-dns-cert.pem and 0-dns-key.pem were stored in `test/fixtures/key` directory, but the cert file cannot be created with the openssl command via Makefile. Added a script to create it with using `asn1.js` and `asn1.js-rfc5280` and moved them out of key directory and put into `test/fixtures/0-dns`. The domains listed in the cert were also changed into example.com and example.org to show the use for only testing. Fixes: nodejs#10228 PR-URL: nodejs#11579 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
0-dns-cert.pem and 0-dns-key.pem were stored in `test/fixtures/key` directory, but the cert file cannot be created with the openssl command via Makefile. Added a script to create it with using `asn1.js` and `asn1.js-rfc5280` and moved them out of key directory and put into `test/fixtures/0-dns`. The domains listed in the cert were also changed into example.com and example.org to show the use for only testing. Fixes: nodejs#10228 PR-URL: nodejs#11579 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2017
0-dns-cert.pem and 0-dns-key.pem were stored in `test/fixtures/key` directory, but the cert file cannot be created with the openssl command via Makefile. Added a script to create it with using `asn1.js` and `asn1.js-rfc5280` and moved them out of key directory and put into `test/fixtures/0-dns`. The domains listed in the cert were also changed into example.com and example.org to show the use for only testing. Fixes: #10228 PR-URL: #11579 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
0-dns-cert.pem and 0-dns-key.pem were stored in `test/fixtures/key` directory, but the cert file cannot be created with the openssl command via Makefile. Added a script to create it with using `asn1.js` and `asn1.js-rfc5280` and moved them out of key directory and put into `test/fixtures/0-dns`. The domains listed in the cert were also changed into example.com and example.org to show the use for only testing. Fixes: #10228 PR-URL: #11579 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
0-dns-cert.pem and 0-dns-key.pem were stored in `test/fixtures/key` directory, but the cert file cannot be created with the openssl command via Makefile. Added a script to create it with using `asn1.js` and `asn1.js-rfc5280` and moved them out of key directory and put into `test/fixtures/0-dns`. The domains listed in the cert were also changed into example.com and example.org to show the use for only testing. Fixes: nodejs/node#10228 PR-URL: nodejs/node#11579 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0-dns-cert.pem and 0-dns-key.pem were stored in
test/fixtures/keydirectory, but the cert file cannot be created with the openssl
command via Makefile.
make cleanremoves them but we could not re-create them.This added a script to create it with using
asn1.jsandasn1.js-rfc5280and moved them out of key directory and put intotest/fixtures/0-dns.The domains listed in the cert were also changed into example.com and
example.org to show the use for only testing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, tls
R: @indutny