test: update test-npm to use test-npm-package.js

[gibfahn]

Also deletes the old test-npm.sh script.

NOTE: Changes to deps/npm are for testing purposes only and won't be landed in the final PR.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

test

This replaces #7867

The tests can be run manually with:

make test-npm

or

vcbuild.bat test-npm

[gibfahn]

cc/ @nodejs/npm @bnoordhuis @Fishrock123 @mscdex @jkrems (from the previous PR)

[gibfahn]

CI: https://ci.nodejs.org/view/MyJobs/job/gibfahn-test-npm/22/ and https://ci.nodejs.org/job/gibfahn-test-npm-win/node=win-vs2015/5/console

[hybrist]

👍

[Fishrock123]

Not sure I follow, as the person who pretty much always does the npm reviews. Why are we changing this?

[gibfahn]

@Fishrock123 do you remember #7867 ? The end result of that PR was that a js script was better than a bash script + a Powershell script (which is what's in #7867). I've got CI jobs set up to run Windows + Unix, and the plan is to be able to do full CI runs on all our platforms.

Note that the script was written by @jkrems for node-inspect, so this just allows us to reuse that script.

EDIT: Note that CI isn't properly passing yet, it'll need to be passing (or only have known npm failures) before this can be merged.

thanks

[jasnell]

ping @gibfahn :-)

[watilde]

This change will be overwritten when we update npm. I think it's better to not edit the files under the dep directory for a specific reason except deps-update.

[gibfahn]

Yeah, I'm just doing this so I can run the tests with the -J option, which is only available in the latest version of tap (that way the tests run 4x faster). This won't land with any changes to deps/npm.

[BridgeAR]

Ping @gibfahn are you still working on this?

[BridgeAR]

Looks like this got rebased and the comments addressed. PTAL @jasnell @nodejs/collaborators

[jasnell]

The change still LGTM

[gibfahn]

Thanks for fixing up the windows tests @refack .

@nodejs/npm does this LGTY? Once this lands I'll fix up the jobs so we have a node-test-commit-npm job collaborators can run.

[BridgeAR]

Ping @nodejs/npm @zkat

[iarna]

I'll dig through this, this week.

[gibfahn]

CI: https://ci.nodejs.org/job/node-test-commit/13179/
CI (npm): https://ci.nodejs.org/view/All/job/gibfahn-test-npm/31/ and https://ci.nodejs.org/job/gibfahn-test-npm-win/node=win-vs2015/9/

[BridgeAR]

I think we can just go ahead and land hits @gibfahn ?

[gibfahn]

Agreed @BridgeAR , it's not perfect, but at least we have the ability to run CI on npm now.

@nodejs/collaborators , you should now have access to:

• https://ci.nodejs.org/view/Node.js/job/node-test-npm/
• https://ci.nodejs.org/view/Node.js/job/node-test-npm-win/

These run make test-npm and vcbuild.bat test-npm.

[MylesBorins]

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.