Update AUTHORS list to reflect new contributions. by aashil · Pull Request #11533 · nodejs/node

aashil · 2017-02-24T05:06:03Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Update the AUTHORS list.
Fixes #11526
Fixes #6403

Trott · 2017-02-24T06:05:20Z

It seems like this adds many duplicate entries (I immediately noticed Ron Korving, Anna Henningsen, Michaël Zasso, and there are probably others...)

EDIT: Imran Iqbal, Minqi Pan/P.S.V.R., ChALkeR and no doubt many more duplicates....

Trott

Many duplicates....

targos · 2017-02-24T07:30:30Z

See #9352 for some duplicate resolutions.

jasnell · 2017-02-24T15:26:33Z

Many of the changes to the existing names should also be reverted. The update should only include the newly added entries that are not duplicates.

silverwind

Please use .mailmap to reduce duplicates and ask users with bogus names/adresses how they want to be represented.

aashil · 2017-02-25T00:51:22Z

@jasnell Thanks. Will do it asap.

jasnell · 2017-02-25T01:30:56Z

Thank you @aashil. It is quite helpful for you to do this and very much appreciated.

aashil · 2017-02-25T01:58:17Z

@jasnell No problem. Should I consider email changes for existing authors? For example, Ron Korving <[email protected]> to Ron Korving <[email protected]>

jasnell · 2017-02-25T02:10:17Z

For those, it's best to at-mention the person in question and ask what they would prefer.

aashil · 2017-02-25T20:18:19Z

The below users might want to use a different name or email. Also, check if you have a duplicate entry with a different name or email in the list. Please let me know and I will update the .mailmap

@ChALkeR
@Alexis374
@atstojanov
@lrlna
@matt-in-a-hat
@delvedor
@oogz
@mpmckenna8
@nohmapp
@ss22ever
@larissayvette
@solebox
@marzelin
@maasencioh
@anu0012
@jseagull
@kobelb
@coderaiser
@jedireza
@timathon
@zzzzBov
@ikasumiwt
@atrioom
@mkamakura
@brad-decker
@makenova
@scalkpdev
@shiya
@stokingerl
@rajatkumar
@bjdelro
@davidmarkclements
@anoff
@k3kathy
@michael6
@CodeTheInternet
@sxa555
@fmizzell
@cdnadmin
@blugavere
@hirabhullar
@codeVana
@eudaimos
@pallxk
@mfhan
@weyj4
@misterpoe
@sivaprs
@malenesok007
@sarahmeyer

aashil · 2017-02-25T20:20:57Z

I guess there is a limit to tag people. Please look at the above comment.

@jBarz
@vitkarpov
@istinson
@richnologies
@legalcodes
@nanxiongchao
@toboid
@jobala
@asafdav2

zzzzBov · 2017-02-26T02:14:52Z

AUTHORS

Timothy Leverett <[email protected]>

Thanks

jedireza · 2017-02-26T04:42:01Z

AUTHORS

Reza Akhavan [email protected]

vitkarpov · 2017-02-26T06:36:04Z

AUTHORS

Viktor Karpov [email protected]

asafdav2 · 2017-02-26T06:39:32Z

AUTHORS

Asaf David [email protected]

toboid · 2017-02-26T09:45:27Z

AUTHORS

Toby Stableford [email protected]

suramya-shah · 2017-02-26T15:00:07Z

AUTHORS

Suramya shah[email protected]

jBarz · 2017-02-26T19:00:12Z

AUTHORS

John Barboza [email protected]

anoff · 2017-02-26T19:57:31Z

AUTHORS

Andreas Offenhaeuser <[email protected]>

Ben Lugavere [email protected]

kobelb · 2017-02-26T20:07:33Z

AUTHORS

Brandon Kobel [email protected]

brad-decker · 2017-02-27T15:18:51Z

AUTHORS

Brad Decker [email protected]

marzelin · 2017-02-27T16:54:13Z

AUTHORS

Marcin Zielinski [email protected]

ChALkeR · 2017-02-27T17:07:39Z

The below users might want to use a different name or email. Also, check if you have a duplicate entry with a different name or email in the list. Please let me know and I will update the .mailmap

My entry in the AUTHORS file seems correct. 😆

kathytruong · 2017-02-27T17:26:39Z

AUTHORS

Kathy Truong [email protected]

richnologies · 2017-02-27T18:09:25Z

AUTHORS

Ricardo Sánchez Gregorio [email protected]

Thanks

legalcodes · 2017-03-01T01:42:04Z

Jon Tippens

[email protected]

Thanks

atstoyanov · 2017-03-01T09:00:13Z

AUTHORS

Angel Stoyanov [email protected]

aashil · 2017-04-17T23:46:25Z

@fhinkel On taking a close look at the script, I found that it is designed to exclude all users with @chromium.org email address. @Trott @jasnell @ChALkeR Is there a reason for this?

https://github.com/nodejs/node/blob/master/tools/update-authors.sh#L11

PS. Who is [email protected] and why is he excluded? Just curious.

jasnell · 2017-04-18T00:01:30Z

Ping @rvagg ... he may have the context for the @chromium.org exclusion.

fhinkel · 2017-04-18T08:08:01Z

I'm assuming we didn't want to count V8 commits (looks like they were imported differently at some point?), AFAIK Erik was on the V8 team. I can change my email address. Sorry for causing confusion by reviewing and committing with different addresses.

fhinkel · 2017-04-18T08:29:47Z

I think @eugeneo and @hashseed use a chromium account, too.

gibfahn · 2017-04-18T09:17:32Z

Sorry for causing confusion by reviewing and committing with different addresses.

@fhinkel looking at the .mailmap I think that's pretty common 😄

aashil · 2017-04-24T16:10:44Z

@Trott @jasnell @ChALkeR All the authors have been included without duplicates. Please approve and merge this PR.

TimothyGu · 2017-04-24T16:17:28Z

.mailmap

+Viktor Karpov <[email protected]> vitkarpov <[email protected]>
 Vincent Voyer <[email protected]>
 Vladimir de Turckheim <[email protected]>
+vsemozhetbyt <[email protected]> Vse Mozhet Byt <[email protected]>


Using Vse's real name would probably be preferred.

Or maybe not the real name 😉, but at least spelled out is better than a network handle

Not sure if I should change that. The original author list had it this way. cc @vsemozhetbyt

It is not a real name, it's a nickname, something like 'anything is possible', 'anything can happen', 'you never know', 'you never can tell' in Russian :) I am OK with either variant, but 'Vse' would be a bit arrogant of me :) — it is actually 'everything, all, everybody' in Russian ) Sorry for the mess) I think it is OK as it is)

[off topic] what is .mailmap used for?

Sometimes people use different name and/or email address in their commits. Mailmap is a way to keep track of that person's preferred username and email address and all the other usernames and email addresses used.

https://git-scm.com/docs/git-shortlog#_mapping_authors

Wow! Thanks for sticking with this! (Was this a NodeTodo thing? I can't remember that far back! :-D)

aashil · 2017-04-25T15:27:16Z

@Trott No problem! This was actually the first issue/work I found myself after the NodeTodo thing. Looking forward to major contributions in the future. Thanks for all the help.

jasnell · 2017-04-25T16:13:06Z

I'll get this landed

PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

jasnell · 2017-04-25T16:18:16Z

Landed in 9d3c06c

aashil · 2017-04-25T16:40:51Z

@jasnell Just wanted to understand what you did for merging. Did you squashed all my commits and then cherry-picked to origin/master?

jasnell · 2017-04-25T16:42:42Z

The workflow is fairly straightforward... I use git am to apply the PR to master, the git rebase -i to squash and edit the commit message so that it includes the appropriate metadata. After that I do a quick make lint followed by git push origin master.

PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

TimothyGu · 2017-04-25T23:27:01Z

@aashil, we have a nice step-by-step patch application process documented in COLLABORATOR_GUIDE.md.

PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

PR-URL: nodejs/node#11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 24, 2017

Trott previously requested changes Feb 24, 2017

View reviewed changes

mscdex added the doc Issues and PRs related to the documentations. label Feb 24, 2017

silverwind suggested changes Feb 24, 2017

View reviewed changes

aashil force-pushed the update-authors branch from 219e573 to 6861a22 Compare February 25, 2017 20:18

zzzzBov suggested changes Feb 26, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

zzzzBov Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timothy Leverett <[email protected]>

Thanks

jedireza reviewed Feb 26, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

jedireza Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reza Akhavan [email protected]

vitkarpov reviewed Feb 26, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

vitkarpov Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Viktor Karpov [email protected]

asafdav2 suggested changes Feb 26, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

asafdav2 Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asaf David [email protected]

toboid reviewed Feb 26, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

toboid Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toby Stableford [email protected]

suramya-shah reviewed Feb 26, 2017

View reviewed changes

AUTHORS Outdated

Copy link

suramya-shah Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suramya shah[email protected]

jBarz reviewed Feb 26, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

jBarz Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

John Barboza [email protected]

anoff reviewed Feb 26, 2017

View reviewed changes

kobelb reviewed Feb 26, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

kobelb Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brandon Kobel [email protected]

brad-decker reviewed Feb 27, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

brad-decker Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brad Decker [email protected]

marzelin reviewed Feb 27, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

marzelin Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marcin Zielinski [email protected]

kathytruong reviewed Feb 27, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

kathytruong Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kathy Truong [email protected]

richnologies reviewed Feb 27, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

richnologies Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ricardo Sánchez Gregorio [email protected]

Thanks

atstoyanov suggested changes Mar 1, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Contributor

atstoyanov Mar 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angel Stoyanov [email protected]

TimothyGu reviewed Apr 24, 2017

View reviewed changes

jasnell approved these changes Apr 24, 2017

View reviewed changes

jasnell pushed a commit that referenced this pull request Apr 25, 2017

meta: update authors list

9d3c06c

PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

jasnell closed this Apr 25, 2017

evanlucas pushed a commit that referenced this pull request Apr 25, 2017

meta: update authors list

b8a76d8

PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

evanlucas mentioned this pull request May 1, 2017

v7.10.0 proposal #12775

Merged

evanlucas pushed a commit that referenced this pull request May 1, 2017

meta: update authors list

ca16010

PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

aashil deleted the update-authors branch May 1, 2017 19:40

evanlucas pushed a commit that referenced this pull request May 2, 2017

meta: update authors list

51eafe8

PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

gibfahn added the land-on-v6.x label May 16, 2017

gibfahn pushed a commit that referenced this pull request May 16, 2017

meta: update authors list

195263e

PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

MylesBorins pushed a commit that referenced this pull request May 18, 2017

meta: update authors list

f20ebf2

PR-URL: #11533 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

MylesBorins mentioned this pull request May 23, 2017

v6.11.0 proposal #13059

Merged

ChALkeR mentioned this pull request May 23, 2017

Remove duplicate entries from the AUTHORS file #6403

Closed

fzn0x mentioned this pull request Jan 25, 2022

build: add nodejs/node update authors integration sequelize/sequelize#13943

Merged

Uh oh!

Conversation

aashil commented Feb 24, 2017 • edited by refack Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

Trott commented Feb 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

targos commented Feb 24, 2017

Uh oh!

jasnell commented Feb 24, 2017

Uh oh!

silverwind left a comment

Choose a reason for hiding this comment

Uh oh!

aashil commented Feb 25, 2017

Uh oh!

jasnell commented Feb 25, 2017

Uh oh!

aashil commented Feb 25, 2017

Uh oh!

jasnell commented Feb 25, 2017

Uh oh!

aashil commented Feb 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aashil commented Feb 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChALkeR commented Feb 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

legalcodes commented Mar 1, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aashil commented Apr 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Apr 18, 2017

Uh oh!

fhinkel commented Apr 18, 2017

Uh oh!

fhinkel commented Apr 18, 2017

Uh oh!

gibfahn commented Apr 18, 2017

Uh oh!

aashil commented Apr 24, 2017

Uh oh!

aashil commented Feb 24, 2017 •

edited by refack

Loading

Trott commented Feb 24, 2017 •

edited

Loading

aashil commented Feb 25, 2017 •

edited

Loading

aashil commented Apr 17, 2017 •

edited

Loading

vsemozhetbyt Apr 24, 2017 •

edited

Loading