Skip to content

test, url: turn on WPT tests on empty params pairs#11369

Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung:sync-wpt
Closed

test, url: turn on WPT tests on empty params pairs#11369
joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung:sync-wpt

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Feb 14, 2017

This is fixed by #11234. This PR turns on the tests accordingly.

Refs: #11234

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url-whatwg, test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 14, 2017
@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Feb 14, 2017
@TimothyGu
Copy link
Member

TimothyGu commented Feb 14, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6399/

TimothyGu
TimothyGu approved these changes Feb 14, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green (except for ARM but the error looks unrelated). LGTM.

@TimothyGu
Copy link
Member

TimothyGu commented Feb 17, 2017

Landed in 82ddf96.

@TimothyGu TimothyGu closed this Feb 17, 2017
TimothyGu pushed a commit that referenced this pull request Feb 17, 2017
@joyeecheung @TimothyGu
test: turn on WPT tests on empty param pairs
82ddf96 
This specific bug was fixed by #11234. This commit turns on the tests
accordingly.

PR-URL: #11369
Ref: #11234
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@TimothyGu TimothyGu TimothyGu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@joyeecheung @TimothyGu @jasnell @cjihrig @italoacasas @gibfahn @nodejs-github-bot