Skip to content

backport: v7.x - #11122 - test: increase coverage of buffer#11312

Closed
DavidCai1111 wants to merge 1 commit intonodejs:v7.x-stagingfrom
DavidCai1111:backport-v7.x-11122
Closed

backport: v7.x - #11122 - test: increase coverage of buffer#11312
DavidCai1111 wants to merge 1 commit intonodejs:v7.x-stagingfrom
DavidCai1111:backport-v7.x-11122

Conversation

@DavidCai1111
Copy link
Member

@DavidCai1111 DavidCai1111 commented Feb 11, 2017

Backport of #11122 to v7.x.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v7.x labels Feb 11, 2017
@hiroppy hiroppy added the buffer Issues and PRs related to the buffer subsystem. label Feb 11, 2017
italoacasas
italoacasas approved these changes Feb 12, 2017
View reviewed changes
Copy link

@italoacasas italoacasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@italoacasas
Copy link

italoacasas commented Feb 15, 2017

@DavidCai1993 can you rebase again, please.

@DavidCai1111
Copy link
Member Author

DavidCai1111 commented Feb 15, 2017

@italoacasas Done, PTAL.

italoacasas pushed a commit that referenced this pull request Feb 16, 2017
@davidtaikocha
test: increase coverage of buffer
f542c59 
PR-URL: #11312
Backport-of: #11122
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@italoacasas
Copy link

italoacasas commented Feb 16, 2017

Landed f542c59. Thanks for the backport.

italoacasas pushed a commit that referenced this pull request Feb 22, 2017
@davidtaikocha
test: increase coverage of buffer
66081d1 
PR-URL: #11312
Backport-of: #11122
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Merged
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

needs a backport pr if it should land on v4 or v6

@gibfahn gibfahn mentioned this pull request Jun 17, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

+2 more reviewers

@thefourtheye thefourtheye thefourtheye approved these changes

@italoacasas italoacasas italoacasas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@DavidCai1111 @italoacasas @jasnell @thefourtheye @hiroppy @nodejs-github-bot @davidtaikocha