Closed
Conversation
Trott
reviewed
Feb 10, 2017
Member
There was a problem hiding this comment.
Can you change the regular expression to match the full error message? /^Error: No key provided to sign$/
Member
|
@nodejs/testing |
Trott
requested changes
Feb 10, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Left a request for a change to the regular expression but other than that, looks good to me. Thanks for the contribution!
akito0107
force-pushed
the
improve-test-crypto-coverage
branch
from
0d59852 to
fc0595e
Compare
Contributor
Author
|
@Trott Thank you for your review! I fixed! |
cjihrig
approved these changes
Feb 10, 2017
santigimeno
approved these changes
Feb 10, 2017
Member
jasnell
approved these changes
Feb 10, 2017
Member
|
This will need to be updated now that the pbkdf2 deprecation has been replaced with a throw |
- call Certificate function directly - check exception when sign option is undefined
akito0107
force-pushed
the
improve-test-crypto-coverage
branch
from
fc0595e to
5e7dbe1
Compare
Contributor
Author
|
@jasnell |
Member
|
So, this PR would be better to add some labels like |
Member
|
This PR does not depend on #11305 so it shouldn't need dont-land-on labels, and that PR is already marked semver-major so dont-land is implicit. |
jasnell
pushed a commit
that referenced
this pull request
Feb 15, 2017
* call Certificate function directly * check exception when sign option is undefined PR-URL: #11280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 036eef1 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 16, 2017
* call Certificate function directly * check exception when sign option is undefined PR-URL: nodejs#11280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
* call Certificate function directly * check exception when sign option is undefined PR-URL: #11280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
* call Certificate function directly * check exception when sign option is undefined PR-URL: #11280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
* call Certificate function directly * check exception when sign option is undefined PR-URL: #11280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* call Certificate function directly * check exception when sign option is undefined PR-URL: #11280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* call Certificate function directly * check exception when sign option is undefined PR-URL: #11280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage on crypto includes as below:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
N/A