test: add coverage for string array dgram send()#11247
Merged
cjihrig merged 1 commit intonodejs:masterfrom Feb 10, 2017
Merged
Conversation
hiroppy
approved these changes
Feb 9, 2017
jasnell
reviewed
Feb 9, 2017
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM but I'm curious: do we / should we test arrays of other data types also?
jasnell
approved these changes
Feb 9, 2017
Contributor
Author
Yea, that code is already covered. |
Contributor
Author
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: nodejs#11247 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
cjihrig
force-pushed
the
string-array
branch
from
bf1121b to
df14956
Compare
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: #11247 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: nodejs#11247 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: nodejs#11247 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: #11247 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: #11247 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds code coverage for
dgram'sSocket#send()where the data is an array of strings.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test