test: validate error message from buffer.equals#11215
Closed
sebbers wants to merge 1 commit intonodejs:masterfrom
Closed
test: validate error message from buffer.equals#11215sebbers wants to merge 1 commit intonodejs:masterfrom
sebbers wants to merge 1 commit intonodejs:masterfrom
Conversation
hiroppy
approved these changes
Feb 7, 2017
cjihrig
approved these changes
Feb 7, 2017
joyeecheung
approved these changes
Feb 7, 2017
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
Can you change the commit message to follow the guidelines, for example, something like test: validate error message from buffer.equals ? Otherwise LGTM. Thanks!
sebbers
changed the title
jasnell
approved these changes
Feb 7, 2017
Member
hiroppy
pushed a commit
to hiroppy/node
that referenced
this pull request
Feb 11, 2017
Adding regular expression as an argument to an assert.throws(). PR-URL: nodejs#11215 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Member
|
Landed in f8cdaaa. Thanks! |
|
This test is failing in |
Member
|
In v7, the error message would be |
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Adding regular expression as an argument to an assert.throws(). PR-URL: nodejs#11215 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
3 tasks
2 tasks
gibfahn
pushed a commit
that referenced
this pull request
Jun 19, 2017
Adding regular expression as an argument to an assert.throws(). PR-URL: #11215 Backport-PR-URL: #13785 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
Adding regular expression as an argument to an assert.throws(). PR-URL: #11215 Backport-PR-URL: #13785 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
Adding regular expression as an argument to an assert.throws(). PR-URL: #11215 Backport-PR-URL: #13785 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Merged
abhishekumar-tyagi
pushed a commit
to abhishekumar-tyagi/node
that referenced
this pull request
May 5, 2024
Adding regular expression as an argument to an assert.throws(). PR-URL: nodejs/node#11215 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a regular expressions to a throw in test/parallel/test-buffer-equals.js