test: add regex by jobala · Pull Request #11193 · nodejs/node

jobala · 2017-02-06T09:18:30Z

Description of task to be completed

Add a regular expression for assert.throws to validate the error message thrown.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

joyeecheung

Can you change the commit message to be more informative, for example, test: verify error message from assert.ifError? Thanks!

joyeecheung · 2017-02-06T09:28:16Z

test/parallel/test-assert.js

                   'a.doesNotThrow is not catching type matching errors');

-assert.throws(function() { assert.ifError(new Error('test error')); });
+assert.throws(function() { assert.ifError(new Error('test error')), /^([A-Za-z])\w+$/});


This regexp is probably too general. Since the error being thrown here is known, can you change that to /^Error: test error$/?

@joyeecheung I do not understand your request, can you please expound.

In this repo we try to make the validation of the error message to be as concrete as possible. For example:

assert.throws( () => { throw new Error('Wrong value'); }, /^Error: Wrong value$/ // Instead of something like /Wrong value/ );

There is an ongoing PR to update our guide on this: #11150

In this line, since according to the documentation of assert.ifError(value):

Throws value if value is truthy.

We are checking that the truthy new Error('test error') passed to assert.ifError() should be rethrown, hence the error message from the block should be /^Error: test error$/

@joyeecheung thanks for taking your time, I now get your point.

cjihrig · 2017-02-06T13:45:50Z

test/parallel/test-assert.js

                   'a.doesNotThrow is not catching type matching errors');

-assert.throws(function() { assert.ifError(new Error('test error')); });
+assert.throws(function() { assert.ifError(new Error('test error')), /^Error: test error/});


I think the regular expression should come after the }. Also, please add a $ to the end of the regex.

@cjihrig thanks for pointing that out, I had missed the part that the regex is the optional argument to assert.throws()

cjihrig · 2017-02-06T14:29:41Z

test/parallel/test-assert.js

                   'a.doesNotThrow is not catching type matching errors');

-assert.throws(function() { assert.ifError(new Error('test error')); });
+assert.throws(function() { assert.ifError(new Error('test error'))}, /^Error: test error$/);


You're going to need to add the semicolon back in.

Also, please add a space before the closing curly brace for symmetry.

hiroppy · 2017-02-07T01:03:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/6249/

jobala · 2017-02-07T09:32:25Z

@abouthiroppy could you know why the tests are failing?

hiroppy · 2017-02-07T09:59:11Z

Please fix this lint error.
381:1 error Line 381 exceeds the maximum line length of 80 max-len

Trott · 2017-02-07T19:31:51Z

The long line has been fixed, but this is still returning a lint error due to indentation problems introduced in the fix for the log line.

@jobala Please run make jslint or vcbuild lint before pushing commits. (If you run make test or vcbuild test, the linting should occur as part of that already.)

thefourtheye · 2017-02-08T02:31:48Z

@Trott Did you mean make lint or vcbuild jslint? :D

thefourtheye

LGTM if CI is green.

Trott · 2017-02-08T03:41:30Z

@Trott Did you mean make lint or vcbuild jslint? :D

Argh! Yeah, vcbuild jslint. Sorry.

jobala · 2017-02-08T18:27:35Z

@Trott thanks for the pointer.

Trott · 2017-02-08T21:55:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/6298/

Verify error message thrown from assert.ifError PR-URL: #11193 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

jasnell · 2017-02-11T21:55:44Z

landed in 5f20d62

Verify error message thrown from assert.ifError PR-URL: #11193 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

Verify error message thrown from assert.ifError PR-URL: nodejs#11193 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

Verify error message thrown from assert.ifError PR-URL: #11193 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

jasnell · 2017-03-07T18:17:25Z

Needs a backport PR to land in v4

Verify error message thrown from assert.ifError PR-URL: #11193 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

test: add regex

3acabec

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 6, 2017

hiroppy added the assert Issues and PRs related to the assert subsystem. label Feb 6, 2017

joyeecheung requested changes Feb 6, 2017

View reviewed changes

test: verify error message thrown from assert.ifError

8870c7f

cjihrig requested changes Feb 6, 2017

View reviewed changes

test: make regex the second argument of assert.throws

ac29f57

cjihrig reviewed Feb 6, 2017

View reviewed changes

test: add space before curly brace

691ce1c

cjihrig approved these changes Feb 6, 2017

View reviewed changes

jasnell approved these changes Feb 6, 2017

View reviewed changes

hiroppy approved these changes Feb 7, 2017

View reviewed changes

joyeecheung approved these changes Feb 7, 2017

View reviewed changes

jobala added 2 commits February 7, 2017 13:09

test: fix exceed maximum lenghth lint error

25527ff

test: fix exceed maximum line length lint error

a7a57e3

thefourtheye approved these changes Feb 8, 2017

View reviewed changes

jobala added 2 commits February 8, 2017 10:20

test: fix indentation lint error

ccab058

Merge branch 'fix-test' of github.com:jobala/node into fix-test

48e3497

jasnell closed this Feb 11, 2017

italoacasas mentioned this pull request Feb 13, 2017

Proposal - 7.6.0 (Current) #11185

Merged

jasnell added the dont-land-on-v4.x label Mar 7, 2017

MylesBorins mentioned this pull request Mar 9, 2017

v6.10.1 proposal #11759

Merged

Uh oh!

Conversation

jobala commented Feb 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of task to be completed

Checklist

Uh oh!

joyeecheung left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hiroppy commented Feb 7, 2017

Uh oh!

jobala commented Feb 7, 2017

Uh oh!

hiroppy commented Feb 7, 2017

Uh oh!

Trott commented Feb 7, 2017

Uh oh!

thefourtheye commented Feb 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thefourtheye left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Feb 8, 2017 • edited by thefourtheye Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jobala commented Feb 8, 2017

Uh oh!

Trott commented Feb 8, 2017

Uh oh!

jasnell commented Feb 11, 2017

Uh oh!

jasnell commented Mar 7, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jobala commented Feb 6, 2017 •

edited

Loading

joyeecheung left a comment •

edited

Loading

thefourtheye commented Feb 8, 2017 •

edited

Loading

Trott commented Feb 8, 2017 •

edited by thefourtheye

Loading