deps: hide zlib internal symbols#11082
Conversation
|
Running a build to see if all our compilers support gcc-style attributes. EDIT: https://ci.nodejs.org/job/node-test-pull-request/6124/ |
|
I've heard
So will have to wait a bit and try again. |
Use HAVE_HIDDEN when compiling zlib so it's internal symbols
have __attribute__((visibility ("hidden"))).
sam-github
force-pushed
the
zlib-use-hidden
branch
from
71c7ccb to
1ae7920
Compare
|
#11085 (comment) should fix, trying again |
sam-github
added
the
semver-major
deps/zlib/zlib.gyp
Outdated
| }, | ||
| 'defines': [ | ||
| 'HAVE_HIDDEN', | ||
| ], |
There was a problem hiding this comment.
Move this to the 'OS!="win"' conditional below. The __attribute__((visibility("hidden"))) doesn't work with Visual Studio (see https://ci.nodejs.org/job/node-compile-windows/6701/label=win-vs2015/consoleFull) and it probably isn't needed anyway because we use deps/zlib/win32/zlib.def to control what is and isn't exported.
Alternatively, if you teach tools/mkssldef.py to generate UNIX linker maps, we can unify the two approaches.
shigeki
left a comment
shigeki
left a comment
There was a problem hiding this comment.
Both gcc and clang support this. CI is green.
Use HAVE_HIDDEN when compiling zlib so it's internal symbols
have __attribute__((visibility ("hidden"))).
PR-URL: #11082
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
|
Landed in c9e5178 |
Use HAVE_HIDDEN when compiling zlib so it's internal symbols
have __attribute__((visibility ("hidden"))).
PR-URL: nodejs#11082
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
5 participants
Use HAVE_HIDDEN when compiling zlib so it's internal symbols
have
__attribute__((visibility ("hidden"))).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps