doc: don't imply that we still do io.js releases#11054
Merged
bnoordhuis merged 1 commit intonodejs:masterfrom Feb 11, 2017
Merged
doc: don't imply that we still do io.js releases#11054bnoordhuis merged 1 commit intonodejs:masterfrom
bnoordhuis merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
targos
approved these changes
Jan 28, 2017
Fishrock123
approved these changes
Jan 28, 2017
Fishrock123
previously requested changes
Jan 28, 2017
README.md
Outdated
Contributor
There was a problem hiding this comment.
Actually, this isn't correct. Most of the current keys were the ones used for signing io.js releases.
Member
There was a problem hiding this comment.
Perhaps with either one of those or one of the following GPG keys? I'm not sure that's the best way to say it, though.
Member
There was a problem hiding this comment.
Or how about
-Releases of Node.js and io.js will be signed with one of the following GPG keys:
+Releases of Node.js will be signed with one of the following GPG keys, so have
+previous releases of io.js:Not the most grammatically correct per se, but it is the most concise I can think of.
Member
Author
There was a problem hiding this comment.
How about I drop the reference to io.js altogether?
Contributor
There was a problem hiding this comment.
Maybe put a line above this one that says: io.js releases may have been signed with any of the keys above or below.
I think hat may be the closest while still easy enough to understand.
Member
There was a problem hiding this comment.
We don't support any of the io.js releases anymore anyway. So +1 on just saying Node.js and leaving it at that.
bnoordhuis
force-pushed
the
update-readme-release-language
branch
from
eb519fd to
e8e3d7b
Compare
Member
Author
|
Reworded, PTAL. |
jasnell
approved these changes
Feb 7, 2017
targos
approved these changes
Feb 7, 2017
cjihrig
approved these changes
Feb 7, 2017
danbev
approved these changes
Feb 8, 2017
Member
Author
|
@Fishrock123 LGTY? |
evanlucas
approved these changes
Feb 8, 2017
Reword the language around releases and signing keys to make it clear that new releases are all branded "Node.js." PR-URL: nodejs#11054 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
bnoordhuis
force-pushed
the
update-readme-release-language
branch
from
e8e3d7b to
1062736
Compare
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
Reword the language around releases and signing keys to make it clear that new releases are all branded "Node.js." PR-URL: #11054 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Reword the language around releases and signing keys to make it clear that new releases are all branded "Node.js." PR-URL: nodejs#11054 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Reword the language around releases and signing keys to make it clear that new releases are all branded "Node.js." PR-URL: nodejs#11054 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Reword the language around releases and signing keys to make it clear that new releases are all branded "Node.js." PR-URL: #11054 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Reword the language around releases and signing keys to make it clear that new releases are all branded "Node.js." PR-URL: #11054 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Reword the language around releases and signing keys to make it clear that new releases are all branded "Node.js." PR-URL: #11054 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Reword the language around releases and signing keys to make it clear that new releases are all branded "Node.js." PR-URL: #11054 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reword the language around releases and signing keys to make it clear
that new releases are all branded "Node.js."
cc @ChALkeR