test, url: break up test-url.js#11049
Closed
joyeecheung wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
joyeecheung
added
the
url
joyeecheung
force-pushed
the
refactor-url-test
branch
from
415352d to
54fbec1
Compare
addaleax
approved these changes
Jan 29, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Rubber-stamp LGTM, this seems to make sense to me.
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/6098/, while waiting for more reviews. |
jasnell
approved these changes
Jan 30, 2017
jasnell
pushed a commit
that referenced
this pull request
Jan 30, 2017
PR-URL: #11049 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Jan 30, 2017
PR-URL: #11049 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
Contributor
|
This isn't landing cleanly on v7.x. Mind submitting a backport PR? |
Member
Author
|
@evanlucas Looks like there is a test depending on #9292, which is semver-major, so this one can be skipped. |
Contributor
|
@joyeecheung Thanks for checking! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break up test-url.js into multiple files by the functionality they test against, so they would be easier to compare with their whatwg url counterparts.
Also remove some unecessary
eslint-disable max-lenand format the error messages using templates(the disabling should be apply to the test cases, which might be inevitably too long, but not to the actual testing code).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, url