test: add known_issues test for #10223

[AnnaMag]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

tests

Description of change

Test addressing #10223 is added to the known_issues directory.
Writable attribute should be false by default.

In v6+ (reverted 524f693) it is set to true irrespective of whether
it was set to false or left out in Object.defineProperty call.
It will be fixed with the 5.5 V8 API changes

[AnnaMag]

cc/ @fhinkel , @bnoordhuis

[cjihrig]

const?

[Trott]

This will be flagged by the linter. It additionally flags that util on line 7 is never used.

[AnnaMag]

Done, thanks

[cjihrig]

Could you use single quotes around "foo" on this line and the next please.

[AnnaMag]

Done, thanks

[bnoordhuis]

LGTM with a suggestion.

[bnoordhuis]

I'd return the descriptor and then check that .writable, .enumerable and .configurable are all false.

[AnnaMag]

suggestion incorporated:)

[AnnaMag]

ah, I just added the check for 'writable'. As a way to compare it all at once, would that work?:

const code = `
   Object.defineProperty(this, 'foo', {value: 5});
   Object.getOwnPropertyDescriptor(this, 'foo');
`;

const desc = vm.runInContext(code, context);

const foo = {value: 5, writable: false, configurable: false, enumerable: true}
assert.strictEqual(desc, foo)

[bnoordhuis]

If you use assert.deepStrictEqual(), it should.

[AnnaMag]

I tried, but I don't think assert.deepStrictEqual() is working as intended...
I tested on a positive example and it throws an error:

const desc = vm.runInContext(code, context);
//desc: { value: 5, writable: true, enumerable: true, configurable: true }

const foo = {value: 5, writable: true, configurable: true, enumerable: true};
assert.deepStrictEqual(desc, foo); // throw new assert.AssertionError

[fhinkel]

Thanks! Landed in e8bb9e6.