doc: fix confusing example in dns.md#11022
doc: fix confusing example in dns.md#11022vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:dns.md
Conversation
nodejs-github-bot
added
dns
|
I'd prefer we avoid corporate entities in our example URLs. Not enough to object to this landing, but enough to suggest some alternatives. (I tested these all and they work in the reverse lookup example in the StackOverflow question, at least.) Maybe use each of these in one example?:
|
Does it mean iteration over hostnames array? |
I mean: There are four code examples changed in this PR. In one of those, use iana.org. In the next one, use wikipedia.org. And so on. Just a suggestion. |
|
@Trott Sorry, there are two examples and two comments for them. So it could be only two hostnames. But these two examples illustrate 'functions belonging to two different categories', i.e. they are used in a somehow comparative way. Should we use different hostnames in them? |
|
Oh, my mistake, I see now, yes, just two examples. I don't think it matters much if you use the same hostname in the two examples or different hostnames in each. It was just an idea. Do whichever you think is better! |
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency.
|
@Trott I've used the |
|
Odd that it happens with |
|
@Trott does this LGTY? |
|
Landed in 110b7cf |
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: #11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: nodejs#11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: #11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: #11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: #11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: #11022 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
5 participants
Checklist
Affected core subsystem(s)
doc, dns
Currently, the second example throws
Error: getHostByAddr ENOTFOUND [IP]. Somebody even posts a question in stackoverflow.com for this very example recently.Unfortunately, more neutral hostnames (like
example.comorgithub.com) produce the same error. So I've replacednodejs.orgbygoogle.com. If I should use something else, please, tell me.The previous adjacent example is edited for consistency.