Move setImmediate benchmarks from misc/ to timers#11010
Closed
joshuacolvin wants to merge 3 commits intonodejs:masterfrom
joshuacolvin:setimmediate
Closed
Move setImmediate benchmarks from misc/ to timers#11010joshuacolvin wants to merge 3 commits intonodejs:masterfrom joshuacolvin:setimmediate
joshuacolvin wants to merge 3 commits intonodejs:masterfrom
joshuacolvin:setimmediate
Conversation
nodejs-github-bot
added
benchmark
mscdex
added
the
timers
Fishrock123
approved these changes
Jan 26, 2017
cjihrig
approved these changes
Jan 26, 2017
Contributor
|
The commit log should have benchmark prefix. Please refer https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit |
evanlucas
approved these changes
Jan 27, 2017
Contributor
evanlucas
left a comment
evanlucas
left a comment
There was a problem hiding this comment.
LGTM with the commit message nit. Thanks!
lpinca
approved these changes
Jan 27, 2017
jasnell
approved these changes
Jan 27, 2017
Contributor
Author
|
Sorry about that! So I've created another commit with the updated commit message (also had to merge remote branch). Should I squash all three together with the correct commit message? |
Member
|
@joshuacolvin that can be done when landing but if you want to help do it :) |
Member
|
Commit title should be 50 chars or less. should work. Edit: or maybe not it's a bit confusing. |
Member
|
will fix the commit message on landing... landing now |
jasnell
pushed a commit
that referenced
this pull request
Jan 30, 2017
PR-URL: #11010 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 1f342af |
evanlucas
pushed a commit
that referenced
this pull request
Jan 31, 2017
PR-URL: #11010 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
PR-URL: #11010 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #11010 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10926