test: increase coverage of internal/util#10964
test: increase coverage of internal/util#10964DavidCai1111 wants to merge 1 commit intonodejs:masterfrom
Conversation
There was a problem hiding this comment.
Does this pass make lint? The comma should be on the previous line.
There was a problem hiding this comment.
The regex should include. ^ and $.
There was a problem hiding this comment.
Why not use assert.doesNotThrow()?
|
@cjihrig OK, updated :) |
| @@ -0,0 +1,12 @@ | |||
| // Flags: --expose-internals | |||
There was a problem hiding this comment.
FWIW, this test won't actually increase test coverage reported at coverage.nodejs.org unless it is run with Node without crypto. And then, it would lose coverage on the else condition.
|
Failures in CI appear to be unrelated. |
PR-URL: #10964 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in a7172b5 |
PR-URL: #10964 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #10964 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
I had to revert this from v6.x-staging due to an error It would appear that |
|
Odd... I was certain I had run that test locally. Likely missing another commit. This one is likely safe to omit |
|
if this gets backported it should come with #11620 |
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test