test: expand test coverage of events.js and fs.js by vinimdocarmo · Pull Request #10947 · nodejs/node

vinimdocarmo · 2017-01-22T04:14:53Z

events.js:

test else path in emitMany function
test calling removeAllListeners() in a event emitter instance
with no events at all
test calling removeListener() passing a event type that does
not exist
test calling eventNames() in a event emitter instance
with no events at all

Refs: https://coverage.nodejs.org/coverage-ba776b3a56642d4c/root/events.js.html

fs.js:

test reading a file passing a not valid enconding

Refs: https://coverage.nodejs.org/coverage-067be658f966dafe/root/internal/fs.js.html

Checklist

make -j4 test (UNIX)
commit message follows commit guidelines

Affected core subsystem(s)

test

jasnell · 2017-01-23T17:31:05Z

It would be better to split these into two separate commits, one for each subsystem for which coverage is being improved.

vinimdocarmo · 2017-01-23T17:32:43Z

@jasnell, I'll do it.

* test else path in emitMany function * test calling removeAllListeners() in a event emitter instance with no events at all * test calling removeListener() passing a event type that does not exist * test calling eventNames() in a event emitter instance with no events at all Refs: https://coverage.nodejs.org/coverage-ba776b3a56642d4c/root/events.js.html

* test reading a file passing a not valid enconding Refs: https://coverage.nodejs.org/coverage-067be658f966dafe/root/internal/fs.js.html

vinimdocarmo · 2017-01-23T17:41:47Z

@jasnell, done!

jasnell

Thank you! LGTM

mhdawson

LGTM. Great to see commits improving our code coverage :)

jasnell · 2017-01-24T02:41:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/6016/

vinimdocarmo · 2017-01-26T12:07:37Z

Any updates about this PR?

gibfahn · 2017-01-26T23:37:05Z

@vinimdocarmo Thanks for the ping, this PR should be good to go, as the CI failure seems unrelated:

https://ci.nodejs.org/job/node-test-binary-arm/6047/RUN_SUBSET=5,label=pi1-raspbian-wheezy/console

not ok 110 parallel/test-npm-install
  ---
  duration_ms: 180.181
  severity: fail
  stack: |-
    timeout
  ...

I'll land this tomorrow if no-one beats me to it.

gibfahn · 2017-01-27T16:33:51Z

Landed in b19334e and bee83e0

* test else path in emitMany function * test calling removeAllListeners() in a event emitter instance with no events at all * test calling removeListener() passing a event type that does not exist * test calling eventNames() in a event emitter instance with no events at all Refs: https://coverage.nodejs.org/coverage-ba776b3a56642d4c/root/events.js.html PR-URL: #10947 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

* test reading a file passing a not valid enconding Refs: https://coverage.nodejs.org/coverage-067be658f966dafe/root/internal/fs.js.html PR-URL: #10947 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

* test else path in emitMany function * test calling removeAllListeners() in a event emitter instance with no events at all * test calling removeListener() passing a event type that does not exist * test calling eventNames() in a event emitter instance with no events at all Refs: https://coverage.nodejs.org/coverage-ba776b3a56642d4c/root/events.js.html PR-URL: #10947 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

* test reading a file passing a not valid enconding Refs: https://coverage.nodejs.org/coverage-067be658f966dafe/root/internal/fs.js.html PR-URL: #10947 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

jasnell · 2017-03-08T23:03:26Z

Both commits landed clean in v6. Only one (the fs.js tests) landed clean in v4. Will need a backport to land the other.

* test else path in emitMany function * test calling removeAllListeners() in a event emitter instance with no events at all * test calling removeListener() passing a event type that does not exist * test calling eventNames() in a event emitter instance with no events at all Refs: https://coverage.nodejs.org/coverage-ba776b3a56642d4c/root/events.js.html PR-URL: #10947 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

* test reading a file passing a not valid enconding Refs: https://coverage.nodejs.org/coverage-067be658f966dafe/root/internal/fs.js.html PR-URL: #10947 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

* test else path in emitMany function * test calling removeAllListeners() in a event emitter instance with no events at all * test calling removeListener() passing a event type that does not exist * test calling eventNames() in a event emitter instance with no events at all Refs: https://coverage.nodejs.org/coverage-ba776b3a56642d4c/root/events.js.html PR-URL: #10947 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

* test reading a file passing a not valid enconding Refs: https://coverage.nodejs.org/coverage-067be658f966dafe/root/internal/fs.js.html PR-URL: #10947 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 22, 2017

mscdex added events Issues and PRs related to the events subsystem / EventEmitter. and removed dont-land-on-v7.x labels Jan 22, 2017

vinimdocarmo force-pushed the extend-tests branch from e088fc2 to 0fd516d Compare January 22, 2017 04:24

nodejs-github-bot added the dont-land-on-v7.x label Jan 22, 2017

mscdex removed the dont-land-on-v7.x label Jan 22, 2017

vinimdocarmo force-pushed the extend-tests branch from 0fd516d to 6c0dc51 Compare January 23, 2017 12:25

nodejs-github-bot added the dont-land-on-v7.x label Jan 23, 2017

vinimdocarmo changed the title ~~test: extend test coverage of events.js~~ test: expand test coverage of events.js and file.js Jan 23, 2017

vinimdocarmo changed the title ~~test: expand test coverage of events.js and file.js~~ test: expand test coverage of events.js and fs.js Jan 23, 2017

vinimdocarmo force-pushed the extend-tests branch from 6c0dc51 to a3ce2b8 Compare January 23, 2017 12:28

nodejs-github-bot added the dont-land-on-v7.x label Jan 23, 2017

vinimdocarmo added 2 commits January 23, 2017 14:40

test: expand test coverage of fs.js

f328546

* test reading a file passing a not valid enconding Refs: https://coverage.nodejs.org/coverage-067be658f966dafe/root/internal/fs.js.html

vinimdocarmo force-pushed the extend-tests branch from a3ce2b8 to f328546 Compare January 23, 2017 17:41

nodejs-github-bot added the dont-land-on-v7.x label Jan 23, 2017

jasnell approved these changes Jan 23, 2017

View reviewed changes

mscdex removed the dont-land-on-v7.x label Jan 23, 2017

mhdawson approved these changes Jan 23, 2017

View reviewed changes

gibfahn approved these changes Jan 26, 2017

View reviewed changes

gibfahn closed this Jan 27, 2017

vinimdocarmo deleted the extend-tests branch January 30, 2017 12:02

italoacasas mentioned this pull request Jan 31, 2017

v7.5.0 proposal #11062

Merged

MylesBorins mentioned this pull request Mar 9, 2017

v6.10.1 proposal #11759

Merged

MylesBorins mentioned this pull request Mar 9, 2017

v4.8.1 proposal #11760

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: expand test coverage of events.js and fs.js#10947

test: expand test coverage of events.js and fs.js#10947
vinimdocarmo wants to merge 2 commits intonodejs:masterfrom
vinimdocarmo:extend-tests

vinimdocarmo commented Jan 22, 2017 •

edited

Loading

Uh oh!

jasnell commented Jan 23, 2017

Uh oh!

vinimdocarmo commented Jan 23, 2017

Uh oh!

vinimdocarmo commented Jan 23, 2017

Uh oh!

jasnell left a comment

Uh oh!

mhdawson left a comment

Uh oh!

jasnell commented Jan 24, 2017

Uh oh!

vinimdocarmo commented Jan 26, 2017

Uh oh!

gibfahn commented Jan 26, 2017

Uh oh!

gibfahn commented Jan 27, 2017

Uh oh!

jasnell commented Mar 8, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

vinimdocarmo commented Jan 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

jasnell commented Jan 23, 2017

Uh oh!

vinimdocarmo commented Jan 23, 2017

Uh oh!

vinimdocarmo commented Jan 23, 2017

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Jan 24, 2017

Uh oh!

vinimdocarmo commented Jan 26, 2017

Uh oh!

gibfahn commented Jan 26, 2017

Uh oh!

gibfahn commented Jan 27, 2017

Uh oh!

jasnell commented Mar 8, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vinimdocarmo commented Jan 22, 2017 •

edited

Loading