test: add dgram.Socket.prototype.sendto's test#10901
test: add dgram.Socket.prototype.sendto's test#10901hiroppy wants to merge 1 commit intonodejs:masterfrom
Conversation
test/parallel/test-dgram-sendto.js
Outdated
There was a problem hiding this comment.
Can you store this regular expression in a variable for reuse.
0dc8717 to
df5c0fa
Compare
test/parallel/test-dgram-sendto.js
Outdated
There was a problem hiding this comment.
No need for the RegExp() constructor.
test/parallel/test-dgram-sendto.js
Outdated
There was a problem hiding this comment.
If all the sendto() calls are supposed to throw before actually sending, and we're verifying the error messages, I don't think binding, listening, and closing the socket is necessary.
df5c0fa to
108934d
Compare
108934d to
8ff8f9c
Compare
|
LGTM if CI is green. I'd leave a nit suggesting being more specific with the identifier name than just |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/5982/ Tip for the link reference you put in the commit message: You can press |
8ff8f9c to
5bacf6e
Compare
|
@targos Thanks :) I modified this commit message. |
|
Landed in 320108c |
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: #10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: nodejs#10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: nodejs#10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: nodejs#10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: nodejs#10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: #10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
failures on v4.x, did not land |
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: #10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
sendto: https://github.com/nodejs/node/blob/master/lib/dgram.js#L234
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test