Closed
Conversation
nodejs-github-bot
added
test
mscdex
added
dgram
jasnell
requested changes
Jan 13, 2017
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
This is close! Left a few comments.
Member
There was a problem hiding this comment.
Please wrap the callback here in common.mustCall()
Member
There was a problem hiding this comment.
common.mustCall() here as well.
Member
There was a problem hiding this comment.
The regex should test the entire error message
hiroppy
force-pushed
the
feature/add-tests-to-dgram
branch
from
ff42392 to
fb2cfdf
Compare
Member
Author
|
@jasnell Updated! PTAL:) |
jasnell
approved these changes
Jan 15, 2017
Member
cjihrig
reviewed
Jan 15, 2017
Contributor
There was a problem hiding this comment.
Can you remove this line please.
cjihrig
approved these changes
Jan 15, 2017
Create test-dgram-multicast-loopback.js for dgram.setMulticastLoopback. Add a test which has an argument of an invalid number to test-dgram-setTTL.js. https://github.com/nodejs/node/blob/master/lib/dgram.js#L464 Add a test which has an argument of a string to test-dgram-multicast-setTTL.js. https://github.com/nodejs/node/blob/master/lib/dgram.js#L473
hiroppy
force-pushed
the
feature/add-tests-to-dgram
branch
from
fb2cfdf to
e2131ec
Compare
|
one more CI before merging |
Member
Author
|
maybe the same reason |
|
Landed 2057a63 |
italoacasas
pushed a commit
that referenced
this pull request
Jan 17, 2017
PR-URL: #10783 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
PR-URL: nodejs#10783 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
PR-URL: nodejs#10783 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
PR-URL: #10783 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10783 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10783 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
PR-URL: #10783 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
PR-URL: #10783 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #10783 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #10783 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create test-dgram-multicast-loopback.js for dgram.setMulticastLoopback.
Add a test which has an argument of an invalid number to test-dgram-setTTL.js.
https://github.com/nodejs/node/blob/master/lib/dgram.js#L464
Add a test which has an argument of a string to test-dgram-multicast-setTTL.js.
https://github.com/nodejs/node/blob/master/lib/dgram.js#L473
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test